Page MenuHomePhabricator

test: Add test for conflicted tx notifications
ClosedPublic

Authored by PiRK on Aug 30 2021, 07:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2f45cfea78bf: test: Add test for conflicted tx notifications
Summary

Add a couple of test for wallet notifications.

Backport notes:

  • The original PR dealt with conflicting transactions due to RBF trickery, which is not possible on the eCash blockchain. So the test is different, we simply create conflicting transactions while the nodes are disconnected.
  • In the original PR, the test for conflicting transactions does not work correctly. We do not observe the same bug. There is a notification for the conflicting transaction, as expected.

This is a backport of core#18878

Test Plan

ninja check-functional

Event Timeline

PiRK requested review of this revision.Aug 30 2021, 07:01

This was supposed to update D9961. I don't know why it created a new diff.

It is D9961, with the test update from D9962 included, to test conflicting transactions.

This revision is now accepted and ready to land.Aug 30 2021, 08:58