Paths

Table of Contentst

Differential D9982

wallet: Remove confusing double return value ret+success
ClosedPublic
Actions

Authored by PiRK on Aug 30 2021, 14:57.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC584ae6ca3bbb: wallet: Remove confusing double return value ret+success

Summary

Also, remove redundant comments

This is a backport of core#19320 [1/2]
https://github.com/bitcoin/bitcoin/pull/19320/commits/fa021e9a5b7e930a3db0febb416942dea3a90a8f

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Aug 30 2021, 14:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2021, 14:57

PiRK requested review of this revision.Aug 30 2021, 14:57

teamcity edited the summary of this revision. (Show Details)Aug 30 2021, 14:57

PiRK added a child revision: D9983: wallet: Replace CDataStream& with CDataStream&& where appropriate.Aug 30 2021, 15:05

Harbormaster completed remote builds in B16471: Diff 29655.Aug 30 2021, 15:20

majcosta added a subscriber: majcosta.Aug 30 2021, 16:38

majcosta accepted this revision.Aug 30 2021, 17:25

majcosta added inline comments.

src/wallet/bdb.h
240 ↗	(On Diff #29655)	braces

This revision is now accepted and ready to land.Aug 30 2021, 17:25

braces

Harbormaster completed remote builds in B16474: Diff 29665.Aug 31 2021, 07:15

Closed by commit rABC584ae6ca3bbb: wallet: Remove confusing double return value ret+success (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyAug 31 2021, 09:18

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC584ae6ca3bbb: wallet: Remove confusing double return value ret+success.

Revision Contents
Changeset List

Path

Size

src/

wallet/

bdb.h

27 lines

bdb.cpp

9 lines

Diff 29675

View Options

src/wallet/bdb.h