Enforce the use of TxId when constructing COutPoint
ClosedPublic
Actions

Authored by deadalnix on Jul 10 2019, 23:49.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING059cdb971905: Enforce the use of TxId when constructing COutPoint
rABC059cdb971905: Enforce the use of TxId when constructing COutPoint

Summary

OutPoint refer to previous transaction ids, and shouldn't accept any hash as input when constructed.

Depends on D3641, D3643, D3644, D3646 and D3645

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

prevouttxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6816
Build 11679: Bitcoin ABC Buildbot (legacy)
Build 11678: arc lint + arc unit

Event Timeline

deadalnix created this revision.Jul 10 2019, 23:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 10 2019, 23:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6816: Diff 10222.Jul 11 2019, 00:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jul 11 2019, 20:02

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/rpc/blockchain.cpp
1162	nit: const
src/rpc/rawtransaction.cpp
488	nit: const
871	nit: const

This revision is now accepted and ready to land.Jul 11 2019, 20:02

Closed by commit rABC059cdb971905: Enforce the use of TxId when constructing COutPoint (authored by deadalnix). · Explain WhyJul 12 2019, 12:26

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC059cdb971905: Enforce the use of TxId when constructing COutPoint.

deadalnix added a commit: rSTAGING059cdb971905: Enforce the use of TxId when constructing COutPoint.Sep 19 2019, 01:13

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

14 lines

primitives/

transaction.h

2 lines

rest.cpp

4 lines

rpc/

blockchain.cpp

6 lines

rawtransaction.cpp

6 lines

test/

coins_tests.cpp

4 lines

denialofservice_tests.cpp

2 lines

sighash_tests.cpp

2 lines

sigopcount_tests.cpp

2 lines

undo_tests.cpp

4 lines

validation_block_tests.cpp

2 lines

txdb.cpp

2 lines

Diff 10222

View Options

src/net_processing.cpp

View Options

src/primitives/transaction.h

View Options

src/rest.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/rawtransaction.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/denialofservice_tests.cpp

View Options

src/test/sighash_tests.cpp

View Options

src/test/sigopcount_tests.cpp

View Options

src/test/undo_tests.cpp

View Options

src/test/validation_block_tests.cpp

View Options

Enforce the use of TxId when constructing COutPointClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 10222

src/net_processing.cpp

src/primitives/transaction.h

src/rest.cpp

src/rpc/blockchain.cpp

src/rpc/rawtransaction.cpp

src/test/coins_tests.cpp

src/test/denialofservice_tests.cpp

src/test/sighash_tests.cpp

src/test/sigopcount_tests.cpp

src/test/undo_tests.cpp

src/test/validation_block_tests.cpp

src/txdb.cpp

Enforce the use of TxId when constructing COutPoint
ClosedPublic
Actions

Revision Contents
Changeset List