Page MenuHomePhabricator

Enforce the use of TxId when constructing COutPoint
ClosedPublic

Authored by deadalnix on Wed, Jul 10, 23:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rABC059cdb971905: Enforce the use of TxId when constructing COutPoint
Summary

OutPoint refer to previous transaction ids, and shouldn't accept any hash as input when constructed.

Depends on D3641, D3643, D3644, D3646 and D3645

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Jul 10, 23:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jul 10, 23:49
jasonbcox accepted this revision.Thu, Jul 11, 20:02
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/rpc/blockchain.cpp
1162 ↗(On Diff #10222)

nit: const

src/rpc/rawtransaction.cpp
488 ↗(On Diff #10222)

nit: const

871 ↗(On Diff #10222)

nit: const

This revision is now accepted and ready to land.Thu, Jul 11, 20:02
This revision was automatically updated to reflect the committed changes.