Page MenuHomePhabricator
Differential D3852

Revert "macOS: Prevent Xcode 9.3 build warnings"
ClosedPublic
Actions

Authored by jasonbcox on Aug 11 2019, 21:50.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings"
rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings"
Summary

This reverts commit 4f0e8a5a102abe5ed647d9f09d69666f9589cdcd.

This should fix the broken Windows binaries in the current release candidate.

Depends on D3851

Test Plan

Fabien to manual test gitian binaries on this patch.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hotfix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7112
Build 12270: Bitcoin ABC Buildbot (legacy)
Build 12269: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Aug 11 2019, 21:50
Herald added a reviewer: deadalnix. · View Herald TranscriptAug 11 2019, 21:50
teamcity added a comment.Aug 11 2019, 21:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 11 2019, 21:51

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

jasonbcox added a child revision: D3853: Bump version to 0.20.0.Aug 11 2019, 21:55
teamcity added a comment.Aug 11 2019, 22:00

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) started.

teamcity added a comment.Aug 11 2019, 22:03

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Aug 11 2019, 22:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7112: Diff 10723.Aug 11 2019, 22:05
Fabien accepted this revision.Aug 12 2019, 06:11
This revision is now accepted and ready to land.Aug 12 2019, 06:11
teamcity added a comment.Aug 12 2019, 07:13

Build Bitcoin-ABC / Resource Intensive Builds / Bitcoin-ABC IBD Diff Testing (w/o checkpoints) passed.

teamcity added a comment.Aug 12 2019, 08:15

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Aug 12 2019, 08:34

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Aug 12 2019, 08:37

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Aug 12 2019, 08:41

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Closed by commit rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings" (authored by jasonbcox). · Explain WhyAug 12 2019, 14:51
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings".
Fabien mentioned this in D3855: Fix missing plural form from commit reversal.Aug 12 2019, 16:12
Fabien mentioned this in rABC36d8a89db509: Fix missing plural form from commit reversal.Aug 13 2019, 07:56
jasonbcox added a commit: rSTAGING29ec9c3571be: Revert "macOS: Prevent Xcode 9.3 build warnings".Sep 19 2019, 01:44
Fabien mentioned this in rSTAGING36d8a89db509: Fix missing plural form from commit reversal.Sep 19 2019, 01:47

Revision Contents
Changeset List

PathSize
6 lines
src/
8 lines

Diff 10723

View Options

configure.ac

Loading...
View Options

src/CMakeLists.txt

Loading...