Paths

Table of Contentst

Differential D3859

Fix incorrect node being checked in segwit recovery test
ClosedPublic
Actions

Authored by jasonbcox on Aug 12 2019, 21:01.

Tags

None

Subscribers

Details

Reviewers

deadalnix
markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGf694f58845f6: Fix incorrect node being checked in segwit recovery test
rABCf694f58845f6: Fix incorrect node being checked in segwit recovery test

Summary

Discovered while working on backports related to send_txs_and_test.
Before this patch, the test happens to pass because the check at line 270 is looking for a tx not being in the mempool of node0, when it should be checking node1 (see calls to check_for_no_ban_on_rejected_tx on node_std at line 270-273).

Test Plan

test_runner.py abc-segwit-recovery

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Aug 12 2019, 21:01

Herald added a reviewer: deadalnix. · View Herald TranscriptAug 12 2019, 21:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7121: Diff 10738.Aug 12 2019, 21:08

oops! that was me :)

This revision is now accepted and ready to land.Aug 12 2019, 22:12

Closed by commit rABCf694f58845f6: Fix incorrect node being checked in segwit recovery test (authored by jasonbcox). · Explain WhyAug 12 2019, 23:20

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCf694f58845f6: Fix incorrect node being checked in segwit recovery test.

jasonbcox added a commit: rSTAGINGf694f58845f6: Fix incorrect node being checked in segwit recovery test.Sep 19 2019, 01:46

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-segwit-recovery.py

2 lines

Diff 10749

test/functional/abc-segwit-recovery.py

Loading...