Page MenuHomePhabricator
Differential D3903

Merge #12752: [MOVEONLY] Move compressor utility functions out of class
ClosedPublic
Actions

Authored by nakihito on Aug 17 2019, 01:07.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGa8d8cd13752b: Merge #12752: [MOVEONLY] Move compressor utility functions out of class
rABCa8d8cd13752b: Merge #12752: [MOVEONLY] Move compressor utility functions out of class
Summary

76a9aac Move compressor utility functions out of class (Pieter Wuille)

Pull request description:

This is a refactor from #10785 with no functionality change.

Move the compresion utility functions out of CScriptCompressor, as a preparation for making the class templated. I'm submitting it as a separate PR as I think it's a general improvement to code readability, and to reduce the diff further on.

Tree-SHA512: 3b3d17c2b96e43f752f512dd573296a6bb15cae165fbe3c79212a0970f5196a62a59a821d5100f29638af1e7461c9171f3dccb8112f005ee08da0ec7fe0073fd

Backport of Core PR12752
https://github.com/bitcoin/bitcoin/pull/12752/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12752
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7194
Build 12433: Bitcoin ABC Buildbot (legacy)
Build 12432: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 17 2019, 01:07
Owners added a reviewer: Restricted Owners Package.Aug 17 2019, 01:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 17 2019, 01:07
teamcity added a comment.Aug 17 2019, 01:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 17 2019, 01:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7184: Diff 10853.Aug 17 2019, 01:17
Fabien requested changes to this revision.Aug 19 2019, 06:33
Fabien added inline comments.
src/test/compress_tests.cpp
33 ↗(On Diff #10853)

Undo

This revision now requires changes to proceed.Aug 19 2019, 06:33
nakihito updated this revision to Diff 10865.Aug 19 2019, 18:19

Fixed nit.

teamcity added a comment.Aug 19 2019, 18:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 19 2019, 18:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7194: Diff 10865.Aug 19 2019, 18:31
Fabien accepted this revision.Aug 19 2019, 19:22
This revision is now accepted and ready to land.Aug 19 2019, 19:22
Closed by commit rABCa8d8cd13752b: Merge #12752: [MOVEONLY] Move compressor utility functions out of class (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyAug 19 2019, 20:14
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCa8d8cd13752b: Merge #12752: [MOVEONLY] Move compressor utility functions out of class.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGa8d8cd13752b: Merge #12752: [MOVEONLY] Move compressor utility functions out of class.Sep 19 2019, 01:54

Revision Contents
Changeset List

PathSize
src/
33 lines
32 lines
test/
9 lines

Diff 10865

View Options

src/compressor.h

Loading...
View Options

src/compressor.cpp

Loading...
View Options

src/test/compress_tests.cpp

Loading...