Page MenuHomePhabricator
Differential D3976

Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)
ClosedPublic
Actions

Authored by nakihito on Aug 30 2019, 01:32.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING1d91c62d1401: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)
rABC1d91c62d1401: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...)
Summary

0bd4cd3 logging: remove unused return value from LogPrintStr (practicalswift)
76f344d logging: Fix potential use-after-free in LogPrintStr(...) (practicalswift)

Pull request description:

Fix potential use-after-free in `LogPrintStr(...)`.

`freopen(…)` frees `m_fileout`.

Tree-SHA512: ceee1f659c10a21525aa648377afeea0a37016339f5269dea54850ba3b475aa316f4931081655717b65f981598fdc9d79a1e79e55f7084c242eeb7bf372bc4b6

Backport of Core PR13148
https://github.com/bitcoin/bitcoin/pull/13148/

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13148
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7287
Build 12619: Bitcoin ABC Buildbot (legacy)
Build 12618: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 30 2019, 01:32
Owners added a reviewer: Restricted Owners Package.Aug 30 2019, 01:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 30 2019, 01:32
teamcity added a comment.Aug 30 2019, 01:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 30 2019, 01:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7287: Diff 11039.Aug 30 2019, 01:43
nakihito planned changes to this revision.Aug 30 2019, 01:44

Not a complete fix. https://github.com/bitcoin/bitcoin/pull/13159 fixes remaining issues.

nakihito requested review of this revision.Aug 30 2019, 20:53
nakihito added a child revision: D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).

Fix completed by D3979.

deadalnix accepted this revision.Aug 31 2019, 14:37
This revision is now accepted and ready to land.Aug 31 2019, 14:37
Closed by commit rABC1d91c62d1401: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...) (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhySep 3 2019, 17:34
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC1d91c62d1401: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING1d91c62d1401: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).Sep 19 2019, 02:06

Revision Contents
Changeset List

PathSize
src/
2 lines
19 lines

Diff 11039

View Options

src/logging.h

Loading...
View Options

src/logging.cpp

Loading...