Page MenuHomePhabricator
Differential D3934

Merge #11338: qt: Backup former GUI settings on `-resetguisettings`
ClosedPublic
Actions

Authored by nakihito on Aug 21 2019, 23:03.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGcbabd40c5b8f: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`
rABCcbabd40c5b8f: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`
Summary

723aa1b qt: Backup former GUI settings on -resetguisettings (Wladimir J. van der Laan)

Pull request description:

Writes the GUI settings to `guisettings.bak` in the data directory before wiping them. This can be used to retroactively troubleshoot issues (e.g. #11262) where `-resetguisettings` solves the problem.
(as discussed in yesterday's IRC meeting)

Tree-SHA512: c64f5052d992eb02057ba285435f143c42d0cc456144a4c565e1c87be833737f9df750d0aee10810f85047c820d9b4f9f22fd94a6f09f4b28a9cf41b63a56586

Backport of Core PR11338
https://github.com/bitcoin/bitcoin/pull/11338/

Test Plan
make check
./bitcoin-qt -resetguisettings
guisettings.ini.bak should exist in your .bitcoin dir

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11338
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7356
Build 12755: Bitcoin ABC Buildbot (legacy)
Build 12754: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 21 2019, 23:03
Owners added a reviewer: Restricted Owners Package.Aug 21 2019, 23:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2019, 23:03
nakihito planned changes to this revision.Aug 21 2019, 23:03
teamcity added a comment.Aug 21 2019, 23:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 21 2019, 23:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7222: Diff 10920.Aug 21 2019, 23:13
jasonbcox requested changes to this revision.Sep 6 2019, 17:53
jasonbcox added inline comments.
src/qt/optionsmodel.cpp
195 ↗(On Diff #10920)

Fix comment

/**
 * ...
214 ↗(On Diff #10920)

remove errant newline

nakihito updated this revision to Diff 11144.Sep 6 2019, 17:57

Fixed comment formatting and removed extra new line.

teamcity added a comment.Sep 6 2019, 17:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7356: Diff 11144.Sep 6 2019, 18:06
teamcity added a comment.Sep 6 2019, 18:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Sep 6 2019, 20:49
This revision is now accepted and ready to land.Sep 6 2019, 20:49
Closed by commit rABCcbabd40c5b8f: Merge #11338: qt: Backup former GUI settings on `-resetguisettings` (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhySep 6 2019, 21:51
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCcbabd40c5b8f: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGcbabd40c5b8f: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.Sep 19 2019, 02:10

Revision Contents
Changeset List

PathSize
doc/
1 line
src/
qt/
22 lines

Diff 11144

View Options

doc/files.md

Loading...
View Options

src/qt/optionsmodel.cpp

Loading...