Page MenuHomePhabricator

Merge #11338: qt: Backup former GUI settings on `-resetguisettings`
ClosedPublic

Authored by nakihito on Aug 21 2019, 23:03.

Details

Summary

723aa1b qt: Backup former GUI settings on -resetguisettings (Wladimir J. van der Laan)

Pull request description:

Writes the GUI settings to `guisettings.bak` in the data directory before wiping them. This can be used to retroactively troubleshoot issues (e.g. #11262) where `-resetguisettings` solves the problem.
(as discussed in yesterday's IRC meeting)

Tree-SHA512: c64f5052d992eb02057ba285435f143c42d0cc456144a4c565e1c87be833737f9df750d0aee10810f85047c820d9b4f9f22fd94a6f09f4b28a9cf41b63a56586

Backport of Core PR11338
https://github.com/bitcoin/bitcoin/pull/11338/

Test Plan
make check
./bitcoin-qt -resetguisettings
guisettings.ini.bak should exist in your .bitcoin dir

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11338
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7356
Build 12755: Bitcoin ABC Buildbot (legacy)
Build 12754: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Aug 21 2019, 23:03
jasonbcox requested changes to this revision.Sep 6 2019, 17:53
jasonbcox added inline comments.
src/qt/optionsmodel.cpp
195 ↗(On Diff #10920)

Fix comment

/**
 * ...
214 ↗(On Diff #10920)

remove errant newline

Fixed comment formatting and removed extra new line.

This revision is now accepted and ready to land.Sep 6 2019, 20:49