Page MenuHomePhabricator
Differential D4080

bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...)
ClosedPublic
Actions

Authored by fpelliccioni on Sep 13 2019, 22:29.

Details

Reviewers
Fabien
deadalnix
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost…
rABCcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost…
Summary
  • Non-Boost is better than Boost.
  • Non-throwing is better than throwing.
  • Explicit error handling is better than implicit error handling.
  • ParseDouble(…) deserves to be used outside of its unit tests :-)

Backport of Bitcoin Core PR13383
https://github.com/bitcoin/bitcoin/pull/13383

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-2722a1f8e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7456
Build 12955: Bitcoin ABC Buildbot (legacy)
Build 12954: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 13 2019, 22:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 13 2019, 22:29
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 13 2019, 22:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7456: Diff 11306.Sep 13 2019, 22:42
teamcity added a comment.Sep 13 2019, 22:42

Build Bitcoin-ABC / Diffs / Diff Testing passed.

deadalnix accepted this revision.Sep 14 2019, 07:49
This revision is now accepted and ready to land.Sep 14 2019, 07:49
deadalnix mentioned this in D4105: Merge #13383: bench: Use non-throwing ParseDouble(...) instead of throwing boost::lexical_cast<double>(...).Sep 19 2019, 08:14
nakihito accepted this revision.Sep 19 2019, 08:16
Closed by commit rABCcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost… (authored by fpelliccioni). · Explain WhySep 20 2019, 12:38
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABCcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost….
fpelliccioni added a commit: rSTAGINGcf2b6f7276f0: bench: Use non-throwing ParseDouble(...) instead of throwing boost….Sep 27 2019, 22:45
Fabien mentioned this in D5136: Prevent wrapping in setexcessiveblock RPC.Feb 3 2020, 10:27
Fabien mentioned this in rABCe7ddc8a7d2c9: Prevent wrapping in setexcessiveblock RPC.Feb 3 2020, 16:18
Fabien mentioned this in rSTAGINGe7ddc8a7d2c9: Prevent wrapping in setexcessiveblock RPC.Apr 7 2020, 22:46

Revision Contents
Changeset List

PathSize
src/
bench/
10 lines

Diff 11306

View Options

src/bench/bench_bitcoin.cpp

Loading...