Add estimate size to dbwrapper
ClosedPublic
Actions

Authored by deadalnix on Aug 31 2017, 20:11.

Details

Reviewers

freetrader
CCulianu
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING2eb72fb63edf: Add estimate size to dbwrapper
rABC2eb72fb63edf: Add estimate size to dbwrapper

Summary

As per title.

Depends on D507

Test Plan

make check

D512 allow to test this better.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

dbwrapperestimate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 812
Build 812: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 31 2017, 20:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 31 2017, 20:11

Ping, rebase

Harbormaster completed remote builds in B843: Diff 1334.Sep 6 2017, 14:57

schancel added a subscriber: schancel.Sep 6 2017, 16:27

schancel added inline comments.

src/dbwrapper.h
87 ↗	(On Diff #1334)	This would be easier to match with the comment if the constants weren't rolled together. However. Seems good.
104 ↗	(On Diff #1334)	I assume varint has some kind of variable encoding that indicates an extra byte?

deadalnix added inline comments.Sep 6 2017, 16:29

src/dbwrapper.h
104 ↗	(On Diff #1334)	Correct.

schancel accepted this revision.Sep 6 2017, 16:32

schancel accepted this revision.Sep 6 2017, 16:35

This revision is now accepted and ready to land.Sep 6 2017, 16:35

Closed by commit rABC2eb72fb63edf: Add estimate size to dbwrapper (authored by deadalnix, committed by deadalnix). · Explain WhySep 6 2017, 16:35

This revision was automatically updated to reflect the committed changes.

deadalnix mentioned this in D512: Store the UTXO set on a per output basis rather than a per transaction basis.Sep 6 2017, 19:11

Revision Contents
Changeset List

Path

Size

src/

dbwrapper.h

21 lines

Diff 1297

View Options

Add estimate size to dbwrapperClosedPublicActions