Page MenuHomePhabricator

Kill ModifyCoin
ClosedPublic

Authored by deadalnix on Aug 14 2017, 23:55.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
Restricted Diffusion Commit
rABC2f67fe3e1c25: Kill ModifyCoin
Summary

This is the last step toward removing the per tx UTXO API and replace it with a per output API. This new API will let us upgrade the storage of the UTXO set on a per output basis.

This is based of work from Pieter Wuille and a continuation of D342 .

Depends on D470

Test Plan

Updated tests

make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Aug 14 2017, 23:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 14 2017, 23:55
CCulianu requested changes to this revision.Aug 19 2017, 01:12

Added some comments.

src/validation.cpp
1521 ↗(On Diff #1175)

Is this entirely safe? Can't compiler optimizer get confused/screwed up by this?

Why not just modify method signature to not be const then?

I strongly suggest you do that and avoid doing this.

This just feels.. *wrong*.

This revision now requires changes to proceed.Aug 19 2017, 01:12
deadalnix added inline comments.Aug 19 2017, 22:40
src/validation.cpp
1521 ↗(On Diff #1175)

I got to agree this feels wrong, hence the comment. This is essentially due to the way the TXO/undo has been stored historically. The problem is that the coin passed in may have missing infos it should have had.

This code will become obsolete once we get ABC to use its own folder, so I assumed this would be good enough.

CCulianu accepted this revision as: CCulianu.Aug 28 2017, 17:15

OK, well I'll accept as myself..

CCulianu accepted this revision.Aug 28 2017, 17:16

.. and as Bitcoin ABC

This revision is now accepted and ready to land.Aug 28 2017, 17:16
This revision was automatically updated to reflect the committed changes.