Page MenuHomePhabricator
Differential D4174

utils: Convert Windows args to utf-8 string
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2019, 20:34.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGc57daa89273c: utils: Convert Windows args to utf-8 string
rABCc57daa89273c: utils: Convert Windows args to utf-8 string
Summary

This is a backport of Core PR13883

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr13883
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7631
Build 13302: Bitcoin ABC Buildbot (legacy)
Build 13301: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 27 2019, 20:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2019, 20:34
teamcity added a comment.Sep 27 2019, 20:34

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the test plan for this revision. (Show Details)Sep 27 2019, 20:34
teamcity added a comment.Sep 27 2019, 20:44

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7619: Diff 13188!Sep 27 2019, 20:44
jasonbcox requested changes to this revision.Sep 27 2019, 21:48
jasonbcox added a subscriber: jasonbcox.

The backport looks ok comparing to the original PR, but the test is broken.

This revision now requires changes to proceed.Sep 27 2019, 21:48
deadalnix updated this revision to Diff 13266.Sep 28 2019, 13:46

Try something

teamcity added a comment.Sep 28 2019, 13:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B7630: Diff 13266!Sep 28 2019, 13:56
teamcity added a comment.Sep 28 2019, 13:56

Build Bitcoin-ABC / Diffs / Diff Testing failed.

deadalnix updated this revision to Diff 13267.Sep 28 2019, 14:17

try more shit

teamcity added a comment.Sep 28 2019, 14:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 28 2019, 14:23

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7631: Diff 13267!Sep 28 2019, 14:23
deadalnix added a comment.Sep 28 2019, 14:30

I have no idea what's happening on CI, none of this is reproducing outside of CI.

teamcity added a comment.Sep 30 2019, 17:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 17:05

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Fabien added a subscriber: Fabien.Sep 30 2019, 17:08

I tried to reproduce on a fresh Debian Stretch, no success.
I will try to install the agent packages and run again.

teamcity added a comment.Sep 30 2019, 17:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 17:15

Build Bitcoin-ABC / Diffs / Diff Testing failed.

teamcity added a comment.Sep 30 2019, 17:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 17:33

Build Bitcoin-ABC / Diffs / Diff Testing failed.

teamcity added a comment.Sep 30 2019, 19:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 19:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 19:11

Build Bitcoin-ABC / Diffs / Diff Testing failed.

jasonbcox mentioned this in D4184: Change CI builds to use utf-8 encoding.Sep 30 2019, 23:06
deadalnix updated this revision to Diff 13283.Oct 1 2019, 12:01

rebase

teamcity added a comment.Oct 1 2019, 12:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 1 2019, 12:11

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7641: Diff 13283!Oct 1 2019, 12:11
jasonbcox mentioned this in rABC4a4b489b0d84: Change CI builds to use utf-8 encoding.Oct 1 2019, 18:56
deadalnix updated this revision to Diff 13307.Oct 1 2019, 19:32

rebase

teamcity added a comment.Oct 1 2019, 19:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 1 2019, 19:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7656: Diff 13307.Oct 1 2019, 19:46
jasonbcox accepted this revision.Oct 1 2019, 20:26
This revision is now accepted and ready to land.Oct 1 2019, 20:26
Closed by commit rABCc57daa89273c: utils: Convert Windows args to utf-8 string (authored by Chun Kuan Lee <ken2812221@gmail.com>, committed by deadalnix). · Explain WhyOct 2 2019, 00:28
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc57daa89273c: utils: Convert Windows args to utf-8 string.
jasonbcox mentioned this in rSTAGING4a4b489b0d84: Change CI builds to use utf-8 encoding.Oct 9 2019, 20:10
deadalnix added a commit: rSTAGINGc57daa89273c: utils: Convert Windows args to utf-8 string.Oct 9 2019, 20:10

Revision Contents
Changeset List

PathSize
src/
5 lines
4 lines
qt/
4 lines
util/
15 lines
29 lines
test/
functional/
4 lines

Diff 13267

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/bitcoind.cpp

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

test/functional/feature_uacomment.py

Loading...