Page MenuHomePhabricator
Differential D4178

validation: Pass tx pool reference into CheckSequenceLocks
ClosedPublic
Actions

Authored by fpelliccioni on Sep 30 2019, 13:17.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks
rABC6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks
Summary

CheckSequenceLocks is called from ATMP and the member function CTxMemPool::removeForReorg without passing in the tx pool object that is used in those function's scope and instead using the global ::mempool instance.

Backport of Bitcoin Core PR13783
https://github.com/bitcoin/bitcoin/pull/13783

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-efaf2d85e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7633
Build 13306: Bitcoin ABC Buildbot (legacy)
Build 13305: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Sep 30 2019, 13:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2019, 13:17
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Sep 30 2019, 13:18

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 30 2019, 13:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7633: Diff 13272.Sep 30 2019, 13:29
deadalnix accepted this revision.Oct 1 2019, 11:32

globavartroll

This revision is now accepted and ready to land.Oct 1 2019, 11:32
Closed by commit rABC6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks (authored by MarcoFalke <falke.marco@gmail.com>, committed by fpelliccioni). · Explain WhyOct 2 2019, 13:04
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABC6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks.
fpelliccioni mentioned this in D4192: validation: Pass tx pool reference into CheckSequenceLocks.Oct 2 2019, 13:05
fpelliccioni added a commit: rSTAGING6518f3585e5e: validation: Pass tx pool reference into CheckSequenceLocks.Oct 9 2019, 20:10

Revision Contents
Changeset List

PathSize
src/
test/
4 lines
2 lines
4 lines
11 lines

Diff 13272

View Options

src/test/miner_tests.cpp

Loading...
View Options

src/txmempool.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...