Page MenuHomePhabricator
Differential D4202

Add 'sethdseed' RPC to initialize or replace HD seed and test
ClosedPublic
Actions

Authored by nakihito on Oct 2 2019, 21:09.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING79e9333ccee7: Add 'sethdseed' RPC to initialize or replace HD seed and test
rABC79e9333ccee7: Add 'sethdseed' RPC to initialize or replace HD seed and test
Summary

The first commit adds a new command sethdseed which allows you to either set or generate a new HD seed to be used. The second commit adds a test for this.

Partial (2/4) backport of Core PR12560
https://github.com/bitcoin/bitcoin/pull/12560/commits/b5ba01a18707b1d50c4d073bd40e1e92d78d04c1
https://github.com/bitcoin/bitcoin/pull/12560/commits/2bcf2b52aea07c778b439e6d6931bb4a1733304

Depends on D4201

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12560-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7672
Build 13383: Bitcoin ABC Buildbot (legacy)
Build 13382: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 2 2019, 21:09
Owners added a reviewer: Restricted Owners Package.Oct 2 2019, 21:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2019, 21:09
nakihito planned changes to this revision.Oct 2 2019, 21:09
teamcity added a comment.Oct 2 2019, 21:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Oct 2 2019, 21:09
nakihito added a parent revision: D4201: Separate HaveKey function that checks whether a key is in a keystore.
teamcity added a comment.Oct 2 2019, 21:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7672: Diff 13327.Oct 2 2019, 21:23
nakihito edited the summary of this revision. (Show Details)Oct 3 2019, 18:42
nakihito requested review of this revision.Oct 3 2019, 19:35
nakihito mentioned this in D4171: Merge #12560: [wallet] Upgrade path for non-HD wallets to HD.
nakihito edited the summary of this revision. (Show Details)
nakihito mentioned this in D4201: Separate HaveKey function that checks whether a key is in a keystore.Oct 3 2019, 20:49
Nico Guiton <nico@bitframe.org> mentioned this in rABC613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore.Oct 3 2019, 20:58
nakihito added a child revision: D4206: Allow -upgradewallet to upgradewallets to HD and use a keypool of presplit keys after upgrading to hd chain split.Oct 4 2019, 21:29
deadalnix accepted this revision.Oct 6 2019, 16:24
This revision is now accepted and ready to land.Oct 6 2019, 16:24
Closed by commit rABC79e9333ccee7: Add 'sethdseed' RPC to initialize or replace HD seed and test (authored by Andrew Chow <achow101-github@achow101.com>, committed by nakihito). · Explain WhyOct 6 2019, 18:44
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC79e9333ccee7: Add 'sethdseed' RPC to initialize or replace HD seed and test.
Nico Guiton <nico@bitframe.org> mentioned this in rSTAGING613514e7d0ef: Separate HaveKey function that checks whether a key is in a keystore.Oct 9 2019, 20:11
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING79e9333ccee7: Add 'sethdseed' RPC to initialize or replace HD seed and test.

Revision Contents
Changeset List

PathSize
src/
qt/
1 line
rpc/
1 line
wallet/
94 lines
5 lines
3 lines
test/
functional/
54 lines

Diff 13327

View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_hd.py

Loading...