Update Seeder to use fsbridge::fopen() instead of fopen()
ClosedPublic
Actions

Authored by nakihito on Oct 5 2019, 22:20.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen()
rABC18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen()

Summary

Updates seeder to use fsbridge::fopen().

Part of the process of cleaning up seeder code.

Test Plan

make
bitcoin-seeder

Confirm the files mentioned below are created and written to after the seeder runs:

dnsseed.dat
dnseed.dump
dnsstats.log

Diff Detail

Repository

rABC Bitcoin ABC

Branch

UpdateSeederfopen

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7696
Build 13431: Bitcoin ABC Buildbot (legacy)
Build 13430: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 5 2019, 22:20

Owners added a reviewer: Restricted Owners Package.Oct 5 2019, 22:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2019, 22:20

nakihito planned changes to this revision.Oct 5 2019, 22:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Oct 5 2019, 22:23

Harbormaster completed remote builds in B7696: Diff 13366.Oct 5 2019, 22:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Oct 7 2019, 23:00

nakihito edited the test plan for this revision. (Show Details)

nakihito added a child revision: D4222: Update seeder files to use fprintf() instead of printf().Oct 7 2019, 23:10

deadalnix accepted this revision.Oct 8 2019, 14:52

This revision is now accepted and ready to land.Oct 8 2019, 14:52

deadalnix mentioned this in D4222: Update seeder files to use fprintf() instead of printf().Oct 8 2019, 14:56

Closed by commit rABC18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen() (authored by nakihito). · Explain WhyOct 8 2019, 16:35

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen().

nakihito removed a child revision: D4222: Update seeder files to use fprintf() instead of printf().Oct 9 2019, 01:12

Nico Guiton <nico@bitframe.org> added a commit: rSTAGING18e435a238b9: Update Seeder to use fsbridge::fopen() instead of fopen().Oct 9 2019, 20:12

Revision Contents
Changeset List

Path

Size

src/

seeder/

main.cpp

10 lines

Diff 13366

View Options

Update Seeder to use fsbridge::fopen() instead of fopen()ClosedPublicActions