Page MenuHomePhabricator
Differential D4220

Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime
ClosedPublic
Actions

Authored by nakihito on Oct 7 2019, 17:39.

Details

Reviewers
deadalnix
Fabien
jasonbcox
fpelliccioni
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime
rABC0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime
Summary

f7e153e95 [wallets] [docs] Add release notes for createwallet RPC. (John Newbery)
32167e830 [wallet] [tests] Add tests for createwallet RPC. (John Newbery)
942131774 [wallet] [rpc] Add createwallet RPC (John Newbery)

Pull request description:

Adds a `createwallet` RPC to dynamically create a new wallet at runtime.

Includes tests and release notes.

Tree-SHA512: e0d89e3ae498234e9db5b827c56804cbab64f18a1875e2b5e676172c110278ea1b9e93a8a61b8dd80e2f2a691490bf229e923e4ccb284a1d3e420b8317815866

Backport of Core PR13058
https://github.com/bitcoin/bitcoin/pull/13058/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13058
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7706
Build 13451: Bitcoin ABC Buildbot (legacy)
Build 13450: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 7 2019, 17:39
Owners added a reviewer: Restricted Owners Package.Oct 7 2019, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2019, 17:39
nakihito planned changes to this revision.Oct 7 2019, 17:39
teamcity added a comment.Oct 7 2019, 17:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7706: Diff 13382.Oct 7 2019, 17:49
teamcity added a comment.Oct 7 2019, 17:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Oct 7 2019, 19:00
nakihito mentioned this in D4226: [wallet] `createwallet` RPC - create new wallet at runtime.Oct 8 2019, 16:27
fpelliccioni added a subscriber: fpelliccioni.Oct 8 2019, 16:44

Related to Github issue 335:
https://github.com/Bitcoin-ABC/bitcoin-abc/issues/335

nakihito added a reviewer: fpelliccioni.Oct 8 2019, 16:58
deadalnix accepted this revision.Oct 8 2019, 17:04
This revision is now accepted and ready to land.Oct 8 2019, 17:04
Closed by commit rABC0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhyOct 8 2019, 17:49
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING0f435ad7cdbe: Merge #13058: [wallet] `createwallet` RPC - create new wallet at runtime.Oct 9 2019, 20:12

Revision Contents
Changeset List

PathSize
doc/
12 lines
src/
wallet/
58 lines
test/
functional/
24 lines

Diff 13382

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...