Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
ClosedPublic
Actions

Authored by fpelliccioni on Oct 7 2019, 17:47.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary…
rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary…

Summary

Make objects in range declarations immutable by default.

Backport of Bitcoin Core PR13249
https://github.com/bitcoin/bitcoin/pull/13249

(D4191 done again)

Test Plan

make check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature-backport-5c24d3b98

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7707
Build 13453: Bitcoin ABC Buildbot (legacy)
Build 13452: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Oct 7 2019, 17:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2019, 17:47

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni mentioned this in D4191: Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations..Oct 7 2019, 17:50

fpelliccioni edited the summary of this revision. (Show Details)Oct 7 2019, 17:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7707: Diff 13383.Oct 7 2019, 18:03

deadalnix accepted this revision.Oct 8 2019, 15:56

deadalnix added inline comments.

src/rpc/blockchain.cpp
503	Interesting :)

This revision is now accepted and ready to land.Oct 8 2019, 15:56

Closed by commit rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by fpelliccioni). · Explain WhyOct 8 2019, 16:08

This revision was automatically updated to reflect the committed changes.

fpelliccioni added a commit: rABC33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary….

fpelliccioni added a commit: rSTAGING33322f23b3d4: Make objects in range declarations immutable by default. Avoid unnecessary….Oct 9 2019, 20:12

Fabien mentioned this in D4283: Fix -Wrange-loop-analysis warnings.Oct 23 2019, 10:08

Fabien mentioned this in rABC71c0a7d5285c: Fix -Wrange-loop-analysis warnings.Oct 23 2019, 15:18

Fabien mentioned this in rSTAGING71c0a7d5285c: Fix -Wrange-loop-analysis warnings.Apr 7 2020, 21:28

Revision Contents
Changeset List

Path

Size

src/

cuckoocache.h

6 lines

net_processing.cpp

2 lines

qt/

2 lines

2 lines

2 lines

2 lines

2 lines

trafficgraphwidget.cpp

4 lines

transactiondesc.cpp

4 lines

transactionrecord.cpp

4 lines

rpc/

blockchain.cpp

2 lines

net.cpp

2 lines

test/

coins_tests.cpp

10 lines

cuckoocache_tests.cpp

6 lines

10 lines

2 lines

5 lines

3 lines

4 lines

4 lines

6 lines

6 lines

wallet/

2 lines

2 lines

2 lines

16 lines

Diff 13383

View Options

src/cuckoocache.h

View Options

src/net_processing.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/splashscreen.cpp

View Options

src/qt/trafficgraphwidget.cpp

View Options

src/qt/transactiondesc.cpp

View Options

src/qt/transactionrecord.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/rpc/net.cpp

View Options

src/test/coins_tests.cpp

View Options

src/test/cuckoocache_tests.cpp

View Options

src/test/dbwrapper_tests.cpp

View Options

src/test/getarg_tests.cpp

View Options

src/test/key_io_tests.cpp

View Options

src/test/skiplist_tests.cpp

View Options

src/test/util_tests.cpp

View Options

src/timedata.cpp

View Options

src/txmempool.cpp

View Options

src/validation.cpp

View Options

src/wallet/db.cpp

View Options

src/wallet/rpcdump.cpp

View Options

src/wallet/rpcwallet.cpp

View Options

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13383

src/cuckoocache.h

src/net_processing.cpp

src/qt/bitcoin.cpp

src/qt/bitcoingui.cpp

src/qt/peertablemodel.cpp

src/qt/sendcoinsdialog.cpp

src/qt/splashscreen.cpp

src/qt/trafficgraphwidget.cpp

src/qt/transactiondesc.cpp

src/qt/transactionrecord.cpp

src/rpc/blockchain.cpp

src/rpc/net.cpp

src/test/coins_tests.cpp

src/test/cuckoocache_tests.cpp

src/test/dbwrapper_tests.cpp

src/test/getarg_tests.cpp

src/test/key_io_tests.cpp

src/test/skiplist_tests.cpp

src/test/util_tests.cpp

src/timedata.cpp

src/txmempool.cpp

src/validation.cpp

src/wallet/db.cpp

src/wallet/rpcdump.cpp

src/wallet/rpcwallet.cpp

src/wallet/wallet.cpp

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
ClosedPublic
Actions

Revision Contents
Changeset List