Page MenuHomePhabricator

Make objects in range declarations immutable by default. Avoid unnecessary copying of objects in range declarations.
ClosedPublic

Authored by fpelliccioni on Oct 7 2019, 17:47.

Details

Summary

Make objects in range declarations immutable by default.

Backport of Bitcoin Core PR13249
https://github.com/bitcoin/bitcoin/pull/13249

(D4191 done again)

Test Plan
make check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-5c24d3b98
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7707
Build 13453: Bitcoin ABC Buildbot (legacy)
Build 13452: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Oct 7 2019, 17:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2019, 17:47
fpelliccioni edited the summary of this revision. (Show Details)Oct 7 2019, 17:52
deadalnix accepted this revision.Oct 8 2019, 15:56
deadalnix added inline comments.
src/rpc/blockchain.cpp
503

Interesting :)

This revision is now accepted and ready to land.Oct 8 2019, 15:56