Page MenuHomePhabricator
Differential D4272

Merge #13114: wallet/keystore: Add Clang thread safety annotations for variables guarded by cs_KeyStore
ClosedPublic
Actions

Authored by nakihito on Oct 20 2019, 22:32.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for…
rABC4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for…
Summary

968b76f77c Add missing cs_KeyStore lock (practicalswift)
4bcd5bb87d Add locking annotations for variables guarded by cs_KeyStore (practicalswift)

Pull request description:

  • Add Clang thread safety annotations for variables guarded by cs_KeyStore
  • Add missing cs_KeyStore lock

Tree-SHA512: 7d93513c2da0cd564b9f1e75aa5156a454a4133eb845020fde8872e685dd5758353e93c33364aeea4a812c08353a810494e503a5ce160cc5be0af5af4bb2e6d7

Backport of Core PR13114
https://github.com/bitcoin/bitcoin/pull/13114/

Test Plan
../configure --enable-debug CXX=clang++ CC=clang
make clean
make check
test_runner.py

Run team city build-werror.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13114
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7861
Build 13741: Bitcoin ABC Buildbot (legacy)
Build 13740: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 20 2019, 22:32
Owners added a reviewer: Restricted Owners Package.Oct 20 2019, 22:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2019, 22:32
nakihito planned changes to this revision.Oct 20 2019, 22:32
teamcity added a comment.Oct 20 2019, 22:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 20 2019, 22:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7819: Diff 13622.Oct 20 2019, 22:43
nakihito requested review of this revision.Oct 21 2019, 17:37
deadalnix requested changes to this revision.Oct 23 2019, 01:13

The test plan is inadequate. If you actually checked for thread safety annotation warning from the compiler, you'd know that there are some since Oct, 3rd (!)

This revision now requires changes to proceed.Oct 23 2019, 01:13
nakihito updated this revision to Diff 13689.Oct 24 2019, 18:05

Rebased.

nakihito planned changes to this revision.Oct 24 2019, 18:05
teamcity added a comment.Oct 24 2019, 18:06

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7861: Diff 13689.Oct 24 2019, 18:17
teamcity added a comment.Oct 24 2019, 18:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Oct 24 2019, 18:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 24 2019, 18:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Oct 24 2019, 18:45
nakihito edited the test plan for this revision. (Show Details)
deadalnix accepted this revision.Oct 25 2019, 01:04
This revision is now accepted and ready to land.Oct 25 2019, 01:04
Closed by commit rABC4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for… (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyOct 25 2019, 01:44
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for….
nakihito added a commit: rSTAGING4db70e1fcd75: Merge #13114: wallet/keystore: Add Clang thread safety annotations for….Apr 7 2020, 21:29

Revision Contents
Changeset List

PathSize
src/
8 lines
wallet/
4 lines
11 lines

Diff 13689

View Options

src/keystore.h

Loading...
View Options

src/wallet/crypter.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...