[CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled
ClosedPublic
Actions

Authored by Fabien on Oct 31 2019, 17:05.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled
rABCfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled

Summary

D4229 introduced the BUILD_LIBBITCOINCONSENSUS switch, and moved the
include(InstallationHelper) directive conditionally. This will prevent
installing other targets when BUILD_LIBBITCOINCONSENSUS is disabled.
This diff fixes the issue by moving the directive to avoid conditional
inclusion.

Test Plan

cmake -GNinja .. -DBUILD_LIBBITCOINCONSENSUS=OFF
ninja install

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Oct 31 2019, 17:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2019, 17:05

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Oct 31 2019, 17:13

This revision is now accepted and ready to land.Oct 31 2019, 17:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7937: Diff 13826.Oct 31 2019, 17:14

Closed by commit rABCfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled (authored by Fabien). · Explain WhyOct 31 2019, 18:21

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled.

Fabien added a commit: rSTAGINGfc49fe70e9bf: [CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

2 lines

Diff 13834

View Options

[CMAKE] Fix missing inclusion when libbitcoinconsensus is disabledClosedPublicActions