Update qt/bitcoin.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 31 2019, 19:57.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING0886c422af1e: Update qt/bitcoin.cpp with Qt5 connect syntax
rABC0886c422af1e: Update qt/bitcoin.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-8c9d79ba40bf702f01685008550ac100

Test Plan

make check
./bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7941
Build 13885: Bitcoin ABC Buildbot (legacy)
Build 13884: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 31 2019, 19:57

Owners added a reviewer: Restricted Owners Package.Oct 31 2019, 19:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 31 2019, 19:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Oct 31 2019, 20:14

This revision is now accepted and ready to land.Oct 31 2019, 20:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7941: Diff 13840.Oct 31 2019, 20:24

Closed by commit rABC0886c422af1e: Update qt/bitcoin.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 20:25

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC0886c422af1e: Update qt/bitcoin.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING0886c422af1e: Update qt/bitcoin.cpp with Qt5 connect syntax.Apr 7 2020, 21:34

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

63 lines

Diff 13840

View Options

Update qt/bitcoin.cpp with Qt5 connect syntaxClosedPublicActions