scripted-diff: test: Remove brackets after assert
ClosedPublic
Actions

Authored by Fabien on Nov 4 2019, 15:52.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGed3d18764a63: scripted-diff: test: Remove brackets after assert
rABCed3d18764a63: scripted-diff: test: Remove brackets after assert

Summary

Partial backport of core PR14954 (commit fa0e65b):
https://github.com/bitcoin/bitcoin/pull/14954/commits/fa0e65b77264476c61832542ab1a9dbedcc738ea#diff-a43dbc1d8db3be80406ee42e2142d7f0

Original scripted-diff:

-BEGIN VERIFY SCRIPT-
sed -i --regexp-extended -e 's/assert ?\((.+)\)(( )*)?(#.*)?$/assert
\1\3\3\4/g' $(git grep -l --extended-regexp 'assert ?\(' test)
-END VERIFY SCRIPT-

Test Plan

./test/functional/test_runner.py --extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14954_part2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7971
Build 13945: Bitcoin ABC Buildbot (legacy)
Build 13944: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 4 2019, 15:52

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 15:52

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7971: Diff 13890.Nov 4 2019, 16:02

jasonbcox accepted this revision.Nov 4 2019, 16:49

This revision is now accepted and ready to land.Nov 4 2019, 16:49

Closed by commit rABCed3d18764a63: scripted-diff: test: Remove brackets after assert (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyNov 4 2019, 20:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCed3d18764a63: scripted-diff: test: Remove brackets after assert.

Fabien added a commit: rSTAGINGed3d18764a63: scripted-diff: test: Remove brackets after assert.Apr 7 2020, 21:35

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-cmdline.py

2 lines

abc-finalize-block.py

2 lines

abc-high_priority_transaction.py

10 lines

abc-magnetic-anomaly-mining.py

6 lines

abc-mempool-coherence-on-activations.py

2 lines

abc-p2p-compactblocks.py

6 lines

abc-parkedchain.py

8 lines

abc-replay-protection.py

22 lines

abc-rpc.py

2 lines

feature_bip68_sequence.py

26 lines

feature_block.py

10 lines

feature_cltv.py

2 lines

feature_csv_activation.py

4 lines

feature_nulldummy.py

2 lines

feature_proxy.py

8 lines

feature_pruning.py

12 lines

interface_bitcoin_cli.py

2 lines

28 lines

5 lines

6 lines

6 lines

mining_getblocktemplate_longpoll.py

10 lines

mining_prioritisetransaction.py

24 lines

38 lines

8 lines

2 lines

6 lines

p2p_unrequested_blocks.py

8 lines

rpc_blockchain.py

6 lines

rpc_fundrawtransaction.py

35 lines

rpc_invalidateblock.py

12 lines

rpc_listtransactions.py

4 lines

rpc_named_arguments.py

2 lines

rpc_preciousblock.py

6 lines

rpc_signmessage.py

12 lines

rpc_uptime.py

2 lines

test_framework/

4 lines

4 lines

4 lines

2 lines

2 lines

4 lines

wallet_abandonconflict.py

6 lines

18 lines

4 lines

8 lines

12 lines

2 lines

lint/

lint-format-strings.py

20 lines

Diff 13890

View Options

test/functional/abc-cmdline.py

View Options

test/functional/abc-finalize-block.py

View Options

test/functional/abc-high_priority_transaction.py

View Options

test/functional/abc-magnetic-anomaly-mining.py

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-p2p-compactblocks.py

View Options

test/functional/abc-parkedchain.py

View Options

test/functional/abc-replay-protection.py

View Options

test/functional/abc-rpc.py

View Options

test/functional/feature_bip68_sequence.py

View Options

test/functional/feature_block.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_csv_activation.py

View Options

test/functional/feature_nulldummy.py

View Options

test/functional/feature_proxy.py

View Options

test/functional/feature_pruning.py

View Options

test/functional/interface_bitcoin_cli.py

View Options

test/functional/interface_http.py

View Options

test/functional/mempool_limit.py

View Options

test/functional/mempool_packages.py

View Options

test/functional/mempool_resurrect.py

View Options

test/functional/mining_getblocktemplate_longpoll.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/p2p_compactblocks.py

View Options

test/functional/p2p_feefilter.py

View Options

test/functional/p2p_invalid_block.py

View Options

test/functional/p2p_leak.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_blockchain.py

View Options

test/functional/rpc_fundrawtransaction.py

View Options

test/functional/rpc_invalidateblock.py

View Options

test/functional/rpc_listtransactions.py

View Options

test/functional/rpc_named_arguments.py

View Options

test/functional/rpc_preciousblock.py

View Options

test/functional/rpc_signmessage.py

View Options

test/functional/rpc_uptime.py

View Options

test/functional/test_framework/address.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/netutil.py

View Options

test/functional/test_framework/schnorr.py

View Options

test/functional/test_framework/socks5.py

View Options

test/functional/test_framework/util.py

View Options

test/functional/wallet_abandonconflict.py

View Options

test/functional/wallet_basic.py

View Options

test/functional/wallet_disable.py

View Options

test/functional/wallet_dump.py

View Options

test/functional/wallet_keypool.py

View Options

test/functional/wallet_labels.py

View Options

test/lint/lint-format-strings.py

scripted-diff: test: Remove brackets after assertClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 13890

test/functional/abc-cmdline.py

test/functional/abc-finalize-block.py

test/functional/abc-high_priority_transaction.py

test/functional/abc-magnetic-anomaly-mining.py

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-p2p-compactblocks.py

test/functional/abc-parkedchain.py

test/functional/abc-replay-protection.py

test/functional/abc-rpc.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_cltv.py

test/functional/feature_csv_activation.py

test/functional/feature_nulldummy.py

test/functional/feature_proxy.py

test/functional/feature_pruning.py

test/functional/interface_bitcoin_cli.py

test/functional/interface_http.py

test/functional/mempool_limit.py

test/functional/mempool_packages.py

test/functional/mempool_resurrect.py

test/functional/mining_getblocktemplate_longpoll.py

test/functional/mining_prioritisetransaction.py

test/functional/p2p_compactblocks.py

test/functional/p2p_feefilter.py

test/functional/p2p_invalid_block.py

test/functional/p2p_leak.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_blockchain.py

test/functional/rpc_fundrawtransaction.py

test/functional/rpc_invalidateblock.py

test/functional/rpc_listtransactions.py

test/functional/rpc_named_arguments.py

test/functional/rpc_preciousblock.py

test/functional/rpc_signmessage.py

test/functional/rpc_uptime.py

test/functional/test_framework/address.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/netutil.py

test/functional/test_framework/schnorr.py

test/functional/test_framework/socks5.py

test/functional/test_framework/util.py

test/functional/wallet_abandonconflict.py

test/functional/wallet_basic.py

test/functional/wallet_disable.py

test/functional/wallet_dump.py

test/functional/wallet_keypool.py

test/functional/wallet_labels.py

test/lint/lint-format-strings.py

scripted-diff: test: Remove brackets after assert
ClosedPublic
Actions

Revision Contents
Changeset List