Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb3dea9dfebe0: [CMAKE] Migrate linux gitian build to cmake and ninja
rABCb3dea9dfebe0: [CMAKE] Migrate linux gitian build to cmake and ninja

Summary

Replace autotools by cmake for the linux gitian builds, and use
ninja as a generator.

Note 1:
The test_bitcoin binary is no longer part of the gitian output.

Note 2: There are some more dependencies required.
This is because CMake is run for the native platform in order to build a
couple helper binaries for secp256k1 and univalue. CMake is run from the
project root and check for all the dependencies despite only a compiler
is required. This is a minor inconvenience which can be reworked later.

Test Plan

Run the Linux gitian build twice.
Check the hashes are identical between the builds.
Run the binaries on all the platforms.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

gitian_linux_cmake

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7983
Build 13968: Bitcoin ABC Buildbot (legacy)
Build 13967: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 2 2019, 11:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2019, 11:34

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7958: Diff 13874.Nov 2 2019, 11:43

Rebase.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Nov 5 2019, 07:30

Fabien removed parent revisions: D4354: [GITIAN] Remove symbolic link to asm for 32-bits gitian build, D4355: [GITIAN] Sort dependencies lexically.

Harbormaster completed remote builds in B7983: Diff 13917.Nov 5 2019, 07:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

You need to be using the libs from depends and not the system libs.

This revision now requires changes to proceed.Nov 10 2019, 12:56

Fabien edited the summary of this revision. (Show Details)Nov 11 2019, 11:52

Fabien added a parent revision: D4425: [CMAKE] Avoid dependencies when building native bin during cross build.

Fabien removed a parent revision: D4350: [CMAKE] Generate the split-debug.sh script.

Reduce the amount of dependencies required by rebasing on top of D4425.
Disable ccache for the build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8056: Diff 14046.Nov 11 2019, 12:13

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing started.

Build Bitcoin-ABC / Resource Intensive Builds / Gitian Builds / Bitcoin-ABC Gitian Diff Testing passed.

Overall it looks good. A few details needs to be changed, though.

contrib/gitian-descriptors/gitian-linux.yml
33 ↗	(On Diff #14046)	I'm not sure if yaml supports comments, but it would be useful to isolate the libraries that are in fact not strictly required, but end up being necessary due to the way the build system works. There is always a danger that these end up being used by mistake and make the build not reproducible. It's much better than it used to, but the trap needs to be made explicit.
55 ↗	(On Diff #14046)	It is probably worth fixing. It doesn't looks like there is any blocker there.
57 ↗	(On Diff #14046)	Avoid moving stuff around unless there is a good reason. This seems to be defined in the same place for all builds, so it's all good.
122 ↗	(On Diff #14046)	It is usually a good idea to use pushd and popd in scripts. Using a better name than build would also be useful, as there are numerous build folder in there, so it means nothing in this context.

This revision now requires changes to proceed.Nov 17 2019, 23:04

deadalnix mentioned this in D4404: [CMAKE] Migrate windows gitian build to cmake and ninja.Nov 17 2019, 23:06

Fabien edited the summary of this revision. (Show Details)Nov 18 2019, 13:55

Fabien removed a parent revision: D4425: [CMAKE] Avoid dependencies when building native bin during cross build.

Rebase and address comments.

deadalnix accepted this revision.Nov 18 2019, 13:59

This revision is now accepted and ready to land.Nov 18 2019, 13:59

Fabien added inline comments.Nov 18 2019, 14:00

contrib/gitian-descriptors/gitian-linux.yml
55 ↗	(On Diff #14046)	This is something I plan to do soon, but I don't think it should block this diff as it doesn't remove anything from current state.