[CMAKE] Add the background image to the dist directory
ClosedPublic
Actions

Authored by Fabien on Nov 5 2019, 15:18.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGa2e804693cdc: [CMAKE] Add the background image to the dist directory
rABCa2e804693cdc: [CMAKE] Add the background image to the dist directory

Summary

This diff generates the background image to be added to the OSX dist
directory. This background image will later be used as the background
for the OSX installer (DMG image).

This background file is expected to be a multi-resolution TIFF image. In
order to allow to change the package name easily, it is constructed from
a SVG file template which is configured at build time.

This SVG file is then converted to multiple DPI raster images, which are
finally concatenated into a single final background TIFF file.

This image transformation process requires several steps, and will
differ between a cross compilation and a native compilation due to the
different tool being available. This diff only support cross
compilation, native platform support will be added later.

Depends on D4380.

Test Plan

ninja osx-deploydir

Check the background.tiff file is added to the dist directory (under
a dedicated .background directory).
Open the TIFF file and check it contains 2 images with different (x2
ratio) resolutions.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_osx_background_cross

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7989
Build 13980: Bitcoin ABC Buildbot (legacy)
Build 13979: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 5 2019, 15:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 15:18

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7989: Diff 13923.Nov 5 2019, 15:27

Fabien added a child revision: D4382: [CMAKE] Build the background dist image on native OSX.Nov 5 2019, 16:54

Fabien added a child revision: D4383: [CMAKE] Complete the dist directory to prepare for the DMG image build.Nov 5 2019, 17:00

jasonbcox requested changes to this revision.Nov 7 2019, 19:19

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

cmake/modules/ImageHelper.cmake
45	Shouldn't CMAKE_SYSTEM_NAME not match "Linux" rather than "Darwin" for the error message to be true?
69	ditto

This revision now requires changes to proceed.Nov 7 2019, 19:19

Fabien requested review of this revision.Nov 7 2019, 19:42

Fabien added inline comments.

cmake/modules/ImageHelper.cmake
45	Hum, no ? The test check that we building for OSX (i.e. Darwin), and not cross compiling, so we are running on native OSX. Then if we fall into this case, the error messages states that it is only supported on Linux, because the only supported build hosts for now (and for some time I think) are OSX and Linux. One can argue that there is some support for windows but it is through WSL or cygwin/mingw which identify as being Linux. Further more if some other host platform is used, then the message remains valid: the tools are only tested valid on Linux.