Page MenuHomePhabricator

[CMAKE] Create a distribution directory with translations
ClosedPublic

Authored by Fabien on Tue, Nov 5, 14:57.

Details

Summary

This diff adds the osx-deploydir target to initiate the dist
directory structure, that will later be used to generate the DMG image
(OSX installer).
The dist directory contains the application bundle augmented with some
Qt translation files to support localization.

Depends on D4379.

Test Plan
ninja osx-deploydir

Check the dist directory contains the application bundle with the
translation files (see the Resources directory inside the application
bundle).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Tue, Nov 5, 14:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 5, 14:57
Fabien updated this revision to Diff 13973.Thu, Nov 7, 14:53

It appears that CMAKE_INSTALL_NAME_TOOL is an existing undocumented CMake variable.
Use it instead of creating a new duplicate, and use the same syntax for otool.

jasonbcox accepted this revision.Thu, Nov 7, 19:12
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
cmake/platforms/OSX.cmake
38 ↗(On Diff #13973)

nit: version the -> version of the

This revision is now accepted and ready to land.Thu, Nov 7, 19:12
This revision was automatically updated to reflect the committed changes.