Page MenuHomePhabricator

[CMAKE] Create a distribution directory with translations
ClosedPublic

Authored by Fabien on Nov 5 2019, 14:57.

Details

Summary

This diff adds the osx-deploydir target to initiate the dist
directory structure, that will later be used to generate the DMG image
(OSX installer).
The dist directory contains the application bundle augmented with some
Qt translation files to support localization.

Depends on D4379.

Test Plan
ninja osx-deploydir

Check the dist directory contains the application bundle with the
translation files (see the Resources directory inside the application
bundle).

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_osx_dist_translations
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7988
Build 13978: Bitcoin ABC Buildbot (legacy)
Build 13977: arc lint + arc unit

Event Timeline

It appears that CMAKE_INSTALL_NAME_TOOL is an existing undocumented CMake variable.
Use it instead of creating a new duplicate, and use the same syntax for otool.

jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
cmake/platforms/OSX.cmake
38 ↗(On Diff #13973)

nit: version the -> version of the

This revision is now accepted and ready to land.Nov 7 2019, 19:12