Page MenuHomePhabricator

[CMAKE] Actually build the DMG image
ClosedPublic

Authored by Fabien on Nov 5 2019, 17:39.

Details

Summary

Now that the dist directory is appropriately set up, the DMG image can
be generated upon.
The method vary depending on whether we are cross compiling from Linux
or running on native OSX.

Depends on D4383.

Test Plan

On linux (with the appropriate cross compilation definitions) and osx:

ninja osx-dmg

Check the DGM is generated and can install the software.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Nov 5 2019, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 17:39
jasonbcox requested changes to this revision.Nov 7 2019, 23:42
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/CMakeLists.txt
528 ↗(On Diff #13927)

Why was -verbose 2 left out?

This revision now requires changes to proceed.Nov 7 2019, 23:42
Fabien requested review of this revision.Nov 8 2019, 07:02
Fabien added inline comments.
src/qt/CMakeLists.txt
528 ↗(On Diff #13927)

Because I don't see the point in having a verbose output during a build, even more if it is active while not requested (it doesn't care about the ninja -v or make VERBOSE=1 flags).
In case of a failure the command line will be displayed and it is easy to run it again with some verbose flag.

Fabien updated this revision to Diff 14044.Nov 11 2019, 09:23

Rebase.

jasonbcox accepted this revision.Nov 11 2019, 21:38
This revision is now accepted and ready to land.Nov 11 2019, 21:38
This revision was automatically updated to reflect the committed changes.