Page MenuHomePhabricator

[CMAKE] Actually build the DMG image
AcceptedPublic

Authored by Fabien on Tue, Nov 5, 17:39.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Summary

Now that the dist directory is appropriately set up, the DMG image can
be generated upon.
The method vary depending on whether we are cross compiling from Linux
or running on native OSX.

Depends on D4383.

Test Plan

On linux (with the appropriate cross compilation definitions) and osx:

ninja osx-dmg

Check the DGM is generated and can install the software.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_osx_dmg
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8054
Build 14103: Bitcoin ABC Buildbot
Build 14102: arc lint + arc unit

Event Timeline

Fabien created this revision.Tue, Nov 5, 17:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 5, 17:39
jasonbcox requested changes to this revision.Thu, Nov 7, 23:42
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/qt/CMakeLists.txt
528 ↗(On Diff #13927)

Why was -verbose 2 left out?

This revision now requires changes to proceed.Thu, Nov 7, 23:42
Fabien requested review of this revision.Fri, Nov 8, 07:02
Fabien added inline comments.
src/qt/CMakeLists.txt
528 ↗(On Diff #13927)

Because I don't see the point in having a verbose output during a build, even more if it is active while not requested (it doesn't care about the ninja -v or make VERBOSE=1 flags).
In case of a failure the command line will be displayed and it is easy to run it again with some verbose flag.

Fabien updated this revision to Diff 14044.Mon, Nov 11, 09:23

Rebase.

jasonbcox accepted this revision.Mon, Nov 11, 21:38
This revision is now accepted and ready to land.Mon, Nov 11, 21:38