[CMAKE] Actually build the DMG image
ClosedPublic
Actions

Authored by Fabien on Nov 5 2019, 17:39.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING1ac53d5605db: [CMAKE] Actually build the DMG image
rABC1ac53d5605db: [CMAKE] Actually build the DMG image

Summary

Now that the dist directory is appropriately set up, the DMG image can
be generated upon.
The method vary depending on whether we are cross compiling from Linux
or running on native OSX.

Depends on D4383.

Test Plan

On linux (with the appropriate cross compilation definitions) and osx:

ninja osx-dmg

Check the DGM is generated and can install the software.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cmake_osx_dmg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8054
Build 14103: Bitcoin ABC Buildbot (legacy)
Build 14102: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 5 2019, 17:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 5 2019, 17:39

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7993: Diff 13927.Nov 5 2019, 17:48

Fabien added a child revision: D4406: [CMAKE] Build a stripped version of the application bundle and use it.Nov 7 2019, 15:12

jasonbcox requested changes to this revision.Nov 7 2019, 23:42

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/qt/CMakeLists.txt
528 ↗	(On Diff #13927)	Why was `-verbose 2` left out?

This revision now requires changes to proceed.Nov 7 2019, 23:42

Fabien requested review of this revision.Nov 8 2019, 07:02

Fabien added inline comments.

src/qt/CMakeLists.txt
528 ↗	(On Diff #13927)	Because I don't see the point in having a verbose output during a build, even more if it is active while not requested (it doesn't care about the `ninja -v` or `make VERBOSE=1` flags). In case of a failure the command line will be displayed and it is easy to run it again with some verbose flag.