Page MenuHomePhabricator
Differential D565

Remove all warning in the seeder
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2017, 10:49.

Details

Reviewers
freetrader
schancel
dagurval
sickpig
Group Reviewers
Restricted Project
Commits
rSTAGINGe9b06b1d7efa: Remove all warning in the seeder
rABCe9b06b1d7efa: Remove all warning in the seeder
Summary

As per title.

Test Plan

Build and check there are no warning anymore.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
seederwarning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 903
Build 903: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 27 2017, 10:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2017, 10:49
deadalnix updated this revision to Diff 1428.Sep 27 2017, 11:03

Remove another warning in protocol.cpp

sickpig added a subscriber: sickpig.Sep 27 2017, 13:23
sickpig added inline comments.
src/seeder/main.cpp
43

what about changing it into Bitcoin-cash-seeder?

sickpig requested changes to this revision.Sep 27 2017, 15:53
This revision now requires changes to proceed.Sep 27 2017, 15:53
deadalnix requested review of this revision.Sep 27 2017, 19:59
deadalnix edited edge metadata.
deadalnix added inline comments.
src/seeder/main.cpp
43

That is completely off topic here.

sickpig accepted this revision.Sep 28 2017, 09:26
sickpig added inline comments.
src/seeder/main.cpp
43

guess so and I saw that you already change it in another diff

This revision is now accepted and ready to land.Sep 28 2017, 09:26
deadalnix updated this revision to Diff 1469.Oct 1 2017, 09:43

Rebase

Harbormaster completed remote builds in B930: Diff 1469.Oct 1 2017, 09:43
Closed by commit rABCe9b06b1d7efa: Remove all warning in the seeder (authored by deadalnix, committed by deadalnix). · Explain WhyOct 3 2017, 09:00
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
seeder/
49 lines
91 lines
62 lines
4 lines
53 lines
7 lines

Diff 1428

View Options

src/seeder/bitcoin.cpp

Loading...
View Options

src/seeder/db.h

Loading...
View Options

src/seeder/db.cpp

Loading...
View Options

src/seeder/dns.h

Loading...
View Options

src/seeder/main.cpp

Loading...
View Options

src/seeder/protocol.cpp

Loading...