Page MenuHomePhabricator
Differential D569

Do some refactoring in pow.cpp to make it easier to introduce new difficulty adjustement algorithm.
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2017, 17:11.

Details

Reviewers
freetrader
schancel
sickpig
dagurval
Group Reviewers
Restricted Project
Commits
rSTAGINGceaf7cbb394f: Do some refactoring in pow.cpp to make it easier to introduce new difficulty…
rABCceaf7cbb394f: Do some refactoring in pow.cpp to make it easier to introduce new difficulty…
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
powrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 908
Build 908: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 27 2017, 17:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2017, 17:11
deadalnix updated this revision to Diff 1436.Sep 28 2017, 08:34

rebase

deadalnix updated this revision to Diff 1441.Sep 28 2017, 17:08

rebase, ping ?

Harbormaster completed remote builds in B913: Diff 1441.Sep 28 2017, 17:08
deadalnix updated this revision to Diff 1448.Sep 29 2017, 10:08

Add the regtest clause up-front rather than in the retargeting code.

Harbormaster completed remote builds in B915: Diff 1448.Sep 29 2017, 10:08
deadalnix updated this revision to Diff 1458.Sep 30 2017, 08:57

Rebase

Harbormaster completed remote builds in B922: Diff 1458.Sep 30 2017, 08:57
schancel added inline comments.Sep 30 2017, 17:53
src/pow.cpp
57 ↗(On Diff #1458)

Does this take care of the logic previously handled by:

if (pindexPrev == nullptr) {

on L16?

deadalnix added inline comments.Sep 30 2017, 18:00
src/pow.cpp
57 ↗(On Diff #1458)

No, line 90 does that.

schancel accepted this revision.Sep 30 2017, 18:04
This revision is now accepted and ready to land.Sep 30 2017, 18:04
Closed by commit rABCceaf7cbb394f: Do some refactoring in pow.cpp to make it easier to introduce new difficulty… (authored by deadalnix, committed by deadalnix). · Explain WhySep 30 2017, 19:51
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
32 lines

Diff 1433

View Options

src/pow.cpp

Loading...