Page MenuHomePhabricator
Differential D4511

Print to console by default when not run with -daemon
ClosedPublic
Actions

Authored by Fabien on Nov 22 2019, 16:50.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf7ce41a3d53f: Print to console by default when not run with -daemon
rABCf7ce41a3d53f: Print to console by default when not run with -daemon
Summary

Printing to the debug log file can be disabled with -nodebulogfile

Backport of core PR13004, PR13614 and PR13625:
https://github.com/bitcoin/bitcoin/pull/13004/files
https://github.com/bitcoin/bitcoin/pull/13614/files
https://github.com/bitcoin/bitcoin/pull/13625/files

Test Plan
./test/functional/test_runner.py feature_logging

Run bitcoind with no argument and check it outputs to console and log
file.
Run bitcoind with -daemon and check it outputs to log file only.
Run bitcoind with -noprinttoconsole and check it outputs to log file
only.
Run bitcoind with -nodebuglogfile and check it outputs console only.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13004
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8255
Build 14535: Default Diff Build & Tests
Build 14534: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 22 2019, 16:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 22 2019, 16:50
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 22 2019, 16:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 22 2019, 17:00

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8231: Diff 14330.Nov 22 2019, 17:00
nakihito added a child revision: D4514: Merge #13055: qt: Don't log to console by default.Nov 22 2019, 21:03
deadalnix accepted this revision.Nov 23 2019, 15:13
deadalnix added inline comments.
src/init.cpp
401 ↗(On Diff #14330)

Consider rebasing on top of D4515

819 ↗(On Diff #14330)

dito

This revision is now accepted and ready to land.Nov 23 2019, 15:13
Fabien updated this revision to Diff 14357.Nov 24 2019, 10:44

Rebase.

teamcity added a comment.Nov 24 2019, 10:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 24 2019, 10:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8255: Diff 14357.Nov 24 2019, 10:54
Closed by commit rABCf7ce41a3d53f: Print to console by default when not run with -daemon (authored by Evan Klitzke <evan@eklitzke.org>, committed by Fabien). · Explain WhyNov 25 2019, 09:16
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCf7ce41a3d53f: Print to console by default when not run with -daemon.
Fabien mentioned this in D4530: Bump version to 0.20.8.Nov 25 2019, 09:51
Fabien mentioned this in rABC82ab51f81ad8: Bump version to 0.20.8.Nov 25 2019, 16:57
Fabien added a commit: rSTAGINGf7ce41a3d53f: Print to console by default when not run with -daemon.Apr 7 2020, 21:48
Fabien mentioned this in rSTAGING82ab51f81ad8: Bump version to 0.20.8.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
52 lines
14 lines
test/
functional/
23 lines
test_framework/
12 lines

Diff 14357

View Options

doc/release-notes.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/logging.cpp

Loading...
View Options

test/functional/feature_logging.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...