Page MenuHomePhabricator

Print to console by default when not run with -daemon
ClosedPublic

Authored by Fabien on Nov 22 2019, 16:50.

Details

Summary

Printing to the debug log file can be disabled with -nodebulogfile

Backport of core PR13004, PR13614 and PR13625:
https://github.com/bitcoin/bitcoin/pull/13004/files
https://github.com/bitcoin/bitcoin/pull/13614/files
https://github.com/bitcoin/bitcoin/pull/13625/files

Test Plan
./test/functional/test_runner.py feature_logging

Run bitcoind with no argument and check it outputs to console and log
file.
Run bitcoind with -daemon and check it outputs to log file only.
Run bitcoind with -noprinttoconsole and check it outputs to log file
only.
Run bitcoind with -nodebuglogfile and check it outputs console only.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13004
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8255
Build 14535: Default Diff Build & Tests
Build 14534: arc lint + arc unit

Event Timeline

deadalnix added inline comments.
src/init.cpp
401 ↗(On Diff #14330)

Consider rebasing on top of D4515

819 ↗(On Diff #14330)

dito

This revision is now accepted and ready to land.Nov 23 2019, 15:13