Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGbe651fb90eb6: [wallet] Support creating a blank wallet
rABCbe651fb90eb6: [wallet] Support creating a blank wallet

Summary

A blank wallet is a wallet that has no keys, script or watch only things.
A new wallet flag indicating that it is blank will be set when the wallet
is blank. Once it is no longer blank (a seed has been generated, keys or
scripts imported, etc), the flag will be unset.

This is a backport of Core PR15226

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 13 2020, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2020, 12:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fix integration test which wa spartially erroneously commented

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8895: Diff 15395.Jan 13 2020, 13:12

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8893: Diff 15393.Jan 13 2020, 13:13

The release notes needs to be updated.

doc/release-notes-15226.md
6 ↗	(On Diff #15395)	I suppose this version number has to be adapted.
7 ↗	(On Diff #15395)	Dito.
src/wallet/wallet.h
1374 ↗	(On Diff #15395)	Fix layout.
test/functional/test_runner.py
80 ↗	(On Diff #15395)	Missing `"wallet_createwallet.py": [["--usecli"]],`
test/functional/timing.json
385 ↗	(On Diff #15395)	Please add `wallet_createwallet.py` and `wallet_createwallet.py -usecli`
test/functional/wallet_createwallet.py
21 ↗	(On Diff #15395)	Note to reviewers: this is not yet in use in our codebase, but it's fine to have it ready for the time the feature is backported.
26 ↗	(On Diff #15395)	Move comment on its own line.

This revision now requires changes to proceed.Jan 13 2020, 15:29

deadalnix added inline comments.Jan 13 2020, 16:31

doc/release-notes-15226.md
7 ↗	(On Diff #15395)	Let's just move this in the release notes.

Redo release notes

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8903: Diff 15407.Jan 13 2020, 16:58

Clearing my queue, waiting for other comments to be addressed.

This revision now requires changes to proceed.Jan 14 2020, 10:01

Address comments

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8927: Diff 15443.Jan 14 2020, 13:02

deadalnix added inline comments.Jan 14 2020, 13:02

test/functional/timing.json
385 ↗	(On Diff #15395)	What if we had a system that run the tests on a regular basis, and therefore know the timing very well, and therefore could not only fill this file is way more accurate and consistent values, but it could do so 100% automatically.

Fabien accepted this revision.Jan 14 2020, 13:22

Fabien added inline comments.

test/functional/wallet_createwallet.py
26 ↗	(On Diff #15443)	There is a tab missing here

This revision is now accepted and ready to land.Jan 14 2020, 13:22

Closed by commit rABCbe651fb90eb6: [wallet] Support creating a blank wallet (authored by Andrew Chow <achow101-github@achow101.com>, committed by deadalnix). · Explain WhyJan 14 2020, 13:25

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCbe651fb90eb6: [wallet] Support creating a blank wallet.

deadalnix added a commit: rSTAGINGbe651fb90eb6: [wallet] Support creating a blank wallet.Apr 7 2020, 22:26

[wallet] Support creating a blank wallet
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 15444

doc/release-notes.md

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/qt/walletmodel.cpp

src/rpc/client.cpp

src/wallet/crypter.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

test/functional/test_runner.py

test/functional/timing.json

test/functional/wallet_createwallet.py

test/functional/wallet_disableprivatekeys.py

[wallet] Support creating a blank walletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 15444

doc/release-notes.md

src/interfaces/wallet.h

src/interfaces/wallet.cpp

src/qt/walletmodel.cpp

src/rpc/client.cpp

src/wallet/crypter.cpp

src/wallet/rpcwallet.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

test/functional/test_runner.py

test/functional/timing.json

test/functional/wallet_createwallet.py

test/functional/wallet_disableprivatekeys.py

[wallet] Support creating a blank wallet
ClosedPublic
Actions

Revision Contents
Changeset List