Paths

Table of Contentst

Differential D5071

remove segwit recovery exemption from SCRIPT_VERIFY_INPUT_SIGCHECKS check
Needs RevisionPublic
Actions

Authored by markblundeberg on Jan 26 2020, 14:40.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

T704: sigChecks implementation

Summary

This exemption isn't actually doing anything since P2SH scriptPubKeys have
no CHECK*SIG* opcodes, and scriptSigs have to be push-only. So this doesn't
currently change any behaviour, and it's simpler to think about in future
without having to consider exemption.

Depends on D5070

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

verifyscript_singlesuccess

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9145
Build 16248: Default Diff Build & Tests
Build 16247: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 26 2020, 14:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 26 2020, 14:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a task: T704: sigChecks implementation.Jan 26 2020, 14:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9145: Diff 15795.Jan 26 2020, 14:46

Clearing my queue for now since the changes requested for the parent D5070 will require updating this diff as well.

This revision now requires changes to proceed.Jan 30 2020, 10:03

no prob :)

Revision Contents
Changeset List

Path

Size

src/

script/

interpreter.cpp

2 lines

2 lines

Diff 15795

src/script/interpreter.cpp

Loading...

src/script/script_flags.h

Loading...