Differential D609

Convert validation.cpp/.h to use Amount class
ClosedPublic
Actions

Authored by schancel on Oct 17 2017, 06:24.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
freetrader

Group Reviewers

Restricted Project

Commits

rSTAGINGa438bb8d5b5e: Convert validation.cpp/.h to use Amount class
rABCa438bb8d5b5e: Convert validation.cpp/.h to use Amount class

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

shammah/validation

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1017
Build 1017: arc lint + arc unit

Event Timeline

schancel created this revision.Oct 17 2017, 06:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2017, 06:24

schancel mentioned this in D604: Convert wallet and qt modules to use Amount struct (T104).Oct 17 2017, 07:10

deadalnix requested changes to this revision.Oct 18 2017, 14:39

deadalnix added inline comments.

src/rpc/rawtransaction.cpp
1115 ↗	(On Diff #1571)	Sounds like this should be an amount as well.
src/validation.cpp
808 ↗	(On Diff #1571)	Remove GetSatoshis.
1168 ↗	(On Diff #1571)	You can probably just return here.
1402 ↗	(On Diff #1571)	Remove GetSatoshis .
1463 ↗	(On Diff #1571)	Remove GetSatoshis.

This revision now requires changes to proceed.Oct 18 2017, 14:39

Remove extraneous GetSatoshi() calls

Harbormaster completed remote builds in B1017: Diff 1595.Oct 20 2017, 03:54

schancel added inline comments.Oct 21 2017, 18:28

src/rpc/rawtransaction.cpp
1115 ↗	(On Diff #1571)	Yes, I was going to convert these files last.

deadalnix accepted this revision.Oct 27 2017, 13:40

This revision is now accepted and ready to land.Oct 27 2017, 13:40

Closed by commit rABCa438bb8d5b5e: Convert validation.cpp/.h to use Amount class (authored by schancel, committed by schancel). · Explain WhyOct 27 2017, 15:48

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

sendcoinsdialog.cpp

3 lines

rpc/

rawtransaction.cpp

2 lines

test/

14 lines

10 lines

39 lines

wallet/

8 lines

Diff 1595

src/qt/sendcoinsdialog.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/test/main_tests.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/wallet/wallet.cpp

Loading...