Page MenuHomePhabricator

Convert validation.cpp/.h to use Amount class
ClosedPublic

Authored by schancel on Oct 17 2017, 06:24.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
shammah/validation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1017
Build 1017: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Oct 18 2017, 14:39
deadalnix added inline comments.
src/rpc/rawtransaction.cpp
1115 ↗(On Diff #1571)

Sounds like this should be an amount as well.

src/validation.cpp
808 ↗(On Diff #1571)

Remove GetSatoshis.

1168 ↗(On Diff #1571)

You can probably just return here.

1402 ↗(On Diff #1571)

Remove GetSatoshis .

1463 ↗(On Diff #1571)

Remove GetSatoshis.

This revision now requires changes to proceed.Oct 18 2017, 14:39
schancel edited edge metadata.
  • Remove extraneous GetSatoshi() calls
src/rpc/rawtransaction.cpp
1115 ↗(On Diff #1571)

Yes, I was going to convert these files last.

This revision is now accepted and ready to land.Oct 27 2017, 13:40
This revision was automatically updated to reflect the committed changes.