Page MenuHomePhabricator
Differential D5160

fix AreInputsStandard sigops counting
ClosedPublic
Actions

Authored by markblundeberg on Feb 5 2020, 10:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T704: sigChecks implementation
Commits
rSTAGINGc0dcb98975da: fix AreInputsStandard sigops counting
rABCc0dcb98975da: fix AreInputsStandard sigops counting
Summary

There is a better sigops counter for P2SH already provided (the
one used by consensus code), and also along the lines of D5061
and D5076 we want all sigops counts to be contextual, never using
internal hardcoded flags.

Test Plan
ninja bench-bitcoin check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
areinputsstandard_sigops
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9274
Build 16489: Default Diff Build & Tests
Build 16488: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 5 2020, 10:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 5 2020, 10:41
teamcity added a comment.Feb 5 2020, 10:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 5 2020, 10:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9274: Diff 16027.Feb 5 2020, 10:47
markblundeberg added a task: T704: sigChecks implementation.Feb 5 2020, 11:11
markblundeberg added a child revision: D5029: deactivate sigops limits in phonon upgrade.Feb 5 2020, 12:36
deadalnix accepted this revision.Feb 5 2020, 16:37
This revision is now accepted and ready to land.Feb 5 2020, 16:37
Closed by commit rABCc0dcb98975da: fix AreInputsStandard sigops counting (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 6 2020, 02:35
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCc0dcb98975da: fix AreInputsStandard sigops counting.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGc0dcb98975da: fix AreInputsStandard sigops counting.Apr 7 2020, 22:49

Revision Contents
Changeset List

PathSize
src/
bench/
3 lines
policy/
4 lines
18 lines
test/
9 lines
3 lines
10 lines

Diff 16027

View Options

src/bench/ccoins_caching.cpp

Loading...
View Options

src/policy/policy.h

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/test/script_p2sh_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/validation.cpp

Loading...