Page MenuHomePhabricator
Differential D5172

Merge #14777: tests: Add regtest for JSON-RPC batch calls
ClosedPublic
Actions

Authored by markblundeberg on Feb 6 2020, 04:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7d55c164e916: Merge #14777: tests: Add regtest for JSON-RPC batch calls
rABC7d55c164e916: Merge #14777: tests: Add regtest for JSON-RPC batch calls
Summary

PR14777 backport.

3d2c7d6f94 Add regtest for JSON-RPC batch calls. (Daniel Kraft)

Pull request description:

This adds a new regtest file `interface_rpc.py`, containing a test for batch JSON-RPC requests.  Those were previously not tested at all.  Tests for basic requests are not really necessary, as those are used anyway in lots of other regtests.

The existing `interface_http.py` file is more about the underlying HTTP connection, so adding a new interface file for the JSON-RPC specific things makes sense.
Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14777
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9291
Build 16519: Default Diff Build & Tests
Build 16518: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 6 2020, 04:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 04:19
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 04:19

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 6 2020, 04:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 6 2020, 04:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9291: Diff 16056.Feb 6 2020, 04:23
markblundeberg added a child revision: D5173: Merge #14982: rpc: Add getrpcinfo command.Feb 6 2020, 04:30
Fabien accepted this revision.Feb 6 2020, 07:51
This revision is now accepted and ready to land.Feb 6 2020, 07:51
Closed by commit rABC7d55c164e916: Merge #14777: tests: Add regtest for JSON-RPC batch calls (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 6 2020, 08:15
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC7d55c164e916: Merge #14777: tests: Add regtest for JSON-RPC batch calls.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING7d55c164e916: Merge #14777: tests: Add regtest for JSON-RPC batch calls.Apr 7 2020, 22:50

Revision Contents
Changeset List

PathSize
test/
functional/
47 lines

Diff 16056

View Options

test/functional/interface_rpc.py

Loading...