Page MenuHomePhabricator
Differential D5224

[standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade
ClosedPublic
Actions

Authored by markblundeberg on Feb 8 2020, 09:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T704: sigChecks implementation
Commits
rSTAGING65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade
rABC65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade
Summary

Just as a standardness rule, limit the per-input sigchecks.

https://github.com/bitcoincashorg/bitcoincash.org/pull/443

Test Plan

ninja check-extended check-upgrade-activated-extended

Rerun ninja check-all with cmake .. -DBUILD_BITCOIN_WALLET=OFF.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
stdsigchecks
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9358
Build 16648: Default Diff Build & Tests
Build 16647: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 8 2020, 09:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2020, 09:30
teamcity added a comment.Feb 8 2020, 09:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg added a task: T704: sigChecks implementation.Feb 8 2020, 09:31
teamcity added a comment.Feb 8 2020, 09:40

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Feb 8 2020, 09:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9358: Diff 16173.Feb 8 2020, 09:40
teamcity added a comment.Feb 8 2020, 10:05

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

deadalnix accepted this revision.Feb 9 2020, 01:23
This revision is now accepted and ready to land.Feb 9 2020, 01:23
markblundeberg updated this revision to Diff 16326.Feb 12 2020, 15:14
markblundeberg edited the summary of this revision. (Show Details)

update after D5130 landing, now the mempool is reprocessed on upgrade so this has no dependencies.

teamcity added a comment.Feb 12 2020, 15:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg removed a parent revision: D5179: [consensus rule] limit sigchecks in a block after phonon upgrade.Feb 12 2020, 15:15
teamcity added a comment.Feb 12 2020, 15:15

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Feb 12 2020, 15:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9462: Diff 16326.Feb 12 2020, 15:24
teamcity added a comment.Feb 12 2020, 15:41

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

markblundeberg updated this revision to Diff 16344.Feb 13 2020, 03:46

update test to work with nowallet build

teamcity added a comment.Feb 13 2020, 03:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg edited the test plan for this revision. (Show Details)Feb 13 2020, 03:46
teamcity added a comment.Feb 13 2020, 03:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9475: Diff 16344.Feb 13 2020, 03:56
markblundeberg updated this revision to Diff 16346.Feb 13 2020, 05:44

just rebase

teamcity added a comment.Feb 13 2020, 05:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)Feb 13 2020, 05:45
teamcity added a comment.Feb 13 2020, 06:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9476: Diff 16346.Feb 13 2020, 06:07
Closed by commit rABC65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 13 2020, 12:02
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.
markblundeberg mentioned this in D5245: [qa] Test that mempool reverts to pre-phonon policies.Feb 14 2020, 02:22
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade.Apr 7 2020, 22:59

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
functional/
310 lines

Diff 16173

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-sigchecks-inputstandardness-activation.py

Loading...