Paths

Table of Contentst

Differential D5373

scripted-diff: replace chainActive -> ::ChainActive()
ClosedPublic
Actions

Authored by nakihito on Feb 28 2020, 22:15.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGd357fa5a29b3: scripted-diff: replace chainActive -> ::ChainActive()
rABCd357fa5a29b3: scripted-diff: replace chainActive -> ::ChainActive()

Summary

Though at the moment ChainActive() simply references g_chainstate.m_chain,
doing this change now clears the way for multiple chainstate usage and allows
us to script the diff.

-BEGIN VERIFY SCRIPT-
git grep -l "chainActive" | grep -E '(h|cpp)$' | xargs sed -i '/chainActive =/b; /extern CChain& chainActive/b; s/\(::\)\{0,1\}chainActive/::ChainActive()/g'
-END VERIFY SCRIPT-

Depends on D5056

Partial backport of Core PR15948
https://github.com/bitcoin/bitcoin/pull/15948/commits/631940aab228ccca64c15e05d5953f40381a0ffc
https://github.com/bitcoin/bitcoin/pull/15948/commits/486c1eea863a41e597ae4fddc392f446f2518b4b

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Feb 28 2020, 22:15

Owners added a reviewer: Restricted Owners Package.Feb 28 2020, 22:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 22:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9650: Diff 16636.Feb 28 2020, 22:27

deadalnix accepted this revision.Feb 29 2020, 00:14

This revision is now accepted and ready to land.Feb 29 2020, 00:14

Closed by commit rABCd357fa5a29b3: scripted-diff: replace chainActive -> ::ChainActive() (authored by nakihito). · Explain WhyMar 2 2020, 19:46

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABCd357fa5a29b3: scripted-diff: replace chainActive -> ::ChainActive().

nakihito added a commit: rSTAGINGd357fa5a29b3: scripted-diff: replace chainActive -> ::ChainActive().Apr 7 2020, 23:12

Revision Contents
Changeset List

Path

Size

src/

2 lines

bench/

duplicate_inputs.cpp

4 lines

index/

16 lines

2 lines

14 lines

interfaces/

8 lines

8 lines

2 lines

net_processing.cpp

130 lines

qt/

test/

wallettests.cpp

2 lines

20 lines

rpc/

48 lines

24 lines

rawtransaction.cpp

10 lines

test/

denialofservice_tests.cpp

4 lines

finalization_tests.cpp

22 lines

miner_tests.cpp

83 lines

test_bitcoin.cpp

4 lines

txvalidationcache_tests.cpp

12 lines

validation_block_tests.cpp

5 lines

2 lines

2 lines

5 lines

157 lines

wallet/

20 lines

16 lines

test/

wallet_tests.cpp

12 lines

57 lines

Diff 16702

src/avalanche.cpp

Loading...

src/bench/duplicate_inputs.cpp

Loading...

src/index/base.cpp

Loading...

src/index/txindex.cpp

Loading...

src/init.cpp

Loading...

src/interfaces/node.cpp

Loading...

src/interfaces/wallet.cpp

Loading...

src/miner.cpp

Loading...

src/net_processing.cpp

Loading...

src/qt/test/wallettests.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/mining.cpp

Loading...

src/rpc/rawtransaction.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

src/test/finalization_tests.cpp

Loading...

src/test/miner_tests.cpp

Loading...

src/test/test_bitcoin.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/test/validation_block_tests.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

src/validation.h

Loading...

src/validation.cpp

Loading...

src/wallet/rpcdump.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...

src/wallet/wallet.cpp

Loading...