Paths

Table of Contentst

Differential D649

Convert the DNS handling code in the seeder to C++
ClosedPublic
Actions

Authored by deadalnix on Nov 8 2017, 11:58.

Tags

None

Subscribers

None

Details

Reviewers

freetrader
sickpig
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING749b4825ef62: Convert the DNS handling code in the seeder to C++
rABC749b4825ef62: Convert the DNS handling code in the seeder to C++

Summary

As per title.

Test Plan

Run the seeder.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

dnscpp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 1074
Build 1074: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 8 2017, 11:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 8 2017, 11:59

Harbormaster completed remote builds in B1074: Diff 1674.Nov 8 2017, 11:59

schancel added inline comments.Nov 8 2017, 14:56

src/seeder/dns.cpp
214	I thought C++ treated all decls as if they were immediately after the start of the function? Should it be initialized to something here? Also `Prdeclare` -> `Predeclare`
360	What's the purpose of this block?
410	Is there a better way to leave debug prints around?

deadalnix added inline comments.Nov 8 2017, 15:03

src/seeder/dns.cpp
410	Yes, using a logging system.

schancel added inline comments.Nov 8 2017, 15:24

src/seeder/dns.cpp
410	If you put a task in with an example of how to do it in the seeder, I can clean these up.

schancel accepted this revision.Nov 8 2017, 16:45

This revision is now accepted and ready to land.Nov 8 2017, 16:45

deadalnix added inline comments.Nov 8 2017, 16:51

src/seeder/dns.cpp
360	Scope declarations.

Closed by commit rABC749b4825ef62: Convert the DNS handling code in the seeder to C++ (authored by deadalnix, committed by deadalnix). · Explain WhyNov 8 2017, 16:51

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

2 lines

seeder/

12 lines

	dns.cpp
	dns.c

372 lines

1 line

Diff 1674

src/Makefile.am

Loading...

src/seeder/dns.h

Loading...

src/seeder/dns.c

Loading...

src/seeder/dns.cpp

Loading...

src/seeder/main.cpp

Loading...