Page MenuHomePhabricator
Differential D5535

Add another UBSAN vptr suppression
ClosedPublic
Actions

Authored by jasonbcox on Mar 22 2020, 23:26.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3eb3dcb04558: Add another UBSAN vptr suppression
rABC3eb3dcb04558: Add another UBSAN vptr suppression
Summary

The recent UBSAN failures ( example: https://build.bitcoinabc.org/viewLog.html?buildId=32136&buildTypeId=BitcoinABC_Master_BitcoinAbcMasterUbsan&tab=buildLog&_focus=2561 ) appear to be triggered by a recent patch ( D5527 ) but I can find no definite root cause within that patch itself. I am able to reproduce this error with clang-8, but tests pass building with clang-9.

Similar to D4848, the exact root cause of this vptr issue is unknown. This patch adds a similar suppression.

Test Plan
ABC_BUILD_NAME=build-ubsan ./contrib/teamcity/build-configurations.sh

export UBSAN_OPTIONS="suppressions=/home/jasonbcox/projects/bitcoin-abc/test/sanitizer_suppressions/ubsan:print_stacktrace=1:halt_on_error=1"
./test/functional/test_runner.py wallet_multiwallet

+ UBSAN on CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ubsan-suppressions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9925
Build 17709: Default Diff Build & Tests
Build 17708: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 22 2020, 23:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 22 2020, 23:26
jasonbcox planned changes to this revision.Mar 22 2020, 23:26
teamcity added a comment.Mar 22 2020, 23:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 22 2020, 23:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-ubsan) started.

jasonbcox edited the summary of this revision. (Show Details)Mar 22 2020, 23:36
teamcity added a comment.Mar 22 2020, 23:36

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9925: Diff 17106.Mar 22 2020, 23:36
jasonbcox edited the test plan for this revision. (Show Details)Mar 22 2020, 23:42
teamcity added a comment.Mar 22 2020, 23:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-ubsan) passed.

jasonbcox requested review of this revision.Mar 23 2020, 00:00
deadalnix accepted this revision.Mar 23 2020, 01:20
This revision is now accepted and ready to land.Mar 23 2020, 01:20
Closed by commit rABC3eb3dcb04558: Add another UBSAN vptr suppression (authored by jasonbcox). · Explain WhyMar 23 2020, 04:01
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC3eb3dcb04558: Add another UBSAN vptr suppression.
nakihito mentioned this in D5534: Revert "Merge #14291: wallet: Add ListWalletDir utility function".Mar 23 2020, 04:41
jasonbcox added a commit: rSTAGING3eb3dcb04558: Add another UBSAN vptr suppression.Apr 7 2020, 23:25

Revision Contents
Changeset List

PathSize
test/
sanitizer_suppressions/
3 lines

Diff 17106

View Options

test/sanitizer_suppressions/ubsan

Loading...