Page MenuHomePhabricator
Differential D5561

Make CWallet::ScanForWalletTransactions args and return value const
ClosedPublic
Actions

Authored by Fabien on Mar 25 2020, 16:24.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4e8e7bf6154d: Make CWallet::ScanForWalletTransactions args and return value const
rABC4e8e7bf6154d: Make CWallet::ScanForWalletTransactions args and return value const
Summary

Partial backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/bb24d686500375564a2137f0940b329b6905bce6

Test Plan
ninja all check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13076_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9963
Build 17778: Default Diff Build & Tests
Build 17777: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 25 2020, 16:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 16:24
teamcity edited the summary of this revision. (Show Details)Mar 25 2020, 16:24

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 25 2020, 16:24

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien added a child revision: D5562: Return a status enum from ScanForWalletTransactions.Mar 25 2020, 16:30
teamcity added a comment.Mar 25 2020, 16:34

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9963: Diff 17163.Mar 25 2020, 16:34
deadalnix accepted this revision.Mar 25 2020, 18:41
This revision is now accepted and ready to land.Mar 25 2020, 18:41
Closed by commit rABC4e8e7bf6154d: Make CWallet::ScanForWalletTransactions args and return value const (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyMar 26 2020, 12:32
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4e8e7bf6154d: Make CWallet::ScanForWalletTransactions args and return value const.
Fabien added a commit: rSTAGING4e8e7bf6154d: Make CWallet::ScanForWalletTransactions args and return value const.Apr 7 2020, 23:28

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
9 lines
8 lines

Diff 17163

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...