Page MenuHomePhabricator
Differential D5563

Add stop_block out arg to ScanForWalletTransactions
ClosedPublic
Actions

Authored by Fabien on Mar 25 2020, 16:39.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING83af2fc46898: Add stop_block out arg to ScanForWalletTransactions
rABC83af2fc46898: Add stop_block out arg to ScanForWalletTransactions
Summary
Accurately reports the last block successfully scanned, replacing a
return of the chain tip, which represented possibly inaccurated data in
a race condition.

Completes backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/bd3b0361d840bff95988a048abf70ade94d80524

Depends on D5562.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13076_part3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9965
Build 17782: Default Diff Build & Tests
Build 17781: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 25 2020, 16:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 16:40
teamcity edited the summary of this revision. (Show Details)Mar 25 2020, 16:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 25 2020, 16:40

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 25 2020, 16:51

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9965: Diff 17165.Mar 25 2020, 16:51
Fabien added a child revision: D5564: wallet: Initialize stop_block to nullptr in ScanForWalletTransactions.Mar 25 2020, 17:16
deadalnix accepted this revision.Mar 25 2020, 18:58
This revision is now accepted and ready to land.Mar 25 2020, 18:58
Closed by commit rABC83af2fc46898: Add stop_block out arg to ScanForWalletTransactions (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyMar 26 2020, 12:34
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC83af2fc46898: Add stop_block out arg to ScanForWalletTransactions.
Fabien added a commit: rSTAGING83af2fc46898: Add stop_block out arg to ScanForWalletTransactions.Apr 7 2020, 23:28

Revision Contents
Changeset List

PathSize
src/
qt/
test/
9 lines
wallet/
6 lines
test/
37 lines
1 line
22 lines

Diff 17165

View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...