Page MenuHomePhabricator
Differential D5568

[avalanche] Fix test when ran without wallet
ClosedPublic
Actions

Authored by deadalnix on Mar 25 2020, 19:45.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGed15a61e72c8: [avalanche] Fix test when ran without wallet
rABCed15a61e72c8: [avalanche] Fix test when ran without wallet
Summary

The generate RPC call require the wallet to be enabled. Use generatetoaddress instead.

Test Plan

Build without wallet and run the test.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avanowallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9973
Build 17796: Default Diff Build & Tests
Build 17795: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 25 2020, 19:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 19:46
teamcity added a comment.Mar 25 2020, 19:46

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

nakihito accepted this revision.Mar 25 2020, 19:47
This revision is now accepted and ready to land.Mar 25 2020, 19:47
teamcity added a comment.Mar 25 2020, 20:07

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9973: Diff 17174.Mar 25 2020, 20:07
Closed by commit rABCed15a61e72c8: [avalanche] Fix test when ran without wallet (authored by deadalnix). · Explain WhyMar 25 2020, 22:54
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCed15a61e72c8: [avalanche] Fix test when ran without wallet.
deadalnix added a commit: rSTAGINGed15a61e72c8: [avalanche] Fix test when ran without wallet.Apr 7 2020, 23:27
jasonbcox mentioned this in D5685: Fix Avalanche functional test when wallet is disabled.Apr 8 2020, 16:06
jasonbcox mentioned this in rABC7ea0deb87926: Fix Avalanche functional test when wallet is disabled.Apr 8 2020, 16:36
jasonbcox mentioned this in rSTAGING7ea0deb87926: Fix Avalanche functional test when wallet is disabled.May 5 2020, 18:54

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines

Diff 17174

View Options

test/functional/abc-p2p-avalanche.py

Loading...