Page MenuHomePhabricator
Differential D553

Make DummyAddress support cashaddr
ClosedPublic
Actions

Authored by dagurval on Sep 21 2017, 23:37.

Details

Reviewers
freetrader
Group Reviewers
Restricted Project
Commits
rSTAGING39aafe4f317b: Make DummyAddress support cashaddr
rABC39aafe4f317b: Make DummyAddress support cashaddr
Summary

Depends on D685

Test Plan

Added unittest.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D553
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1123
Build 1123: arc lint + arc unit

Event Timeline

dagurval created this revision.Sep 21 2017, 23:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 21 2017, 23:37
Harbormaster completed remote builds in B880: Diff 1400.Sep 21 2017, 23:37
dagurval edited the summary of this revision. (Show Details)Sep 21 2017, 23:37
dagurval added a parent revision: D544: Use the new cashaddr format.
dagurval added a child revision: D583: Support parsing cashaddr from command line.Oct 4 2017, 21:50
dagurval planned changes to this revision.Nov 7 2017, 08:21
dagurval updated this revision to Diff 1747.Nov 15 2017, 11:23

Type of address generated depends on config now. Added test.

Harbormaster completed remote builds in B1123: Diff 1747.Nov 15 2017, 11:23
dagurval retitled this revision from [cashaddr] Make DummyAddress generate a dummy cashaddr to Make DummyAddress support cashaddr.Nov 15 2017, 11:25
dagurval edited the summary of this revision. (Show Details)
dagurval edited the test plan for this revision. (Show Details)
dagurval added a parent revision: D685: Added DummyConfig.
freetrader accepted this revision.Nov 16 2017, 01:34
This revision is now accepted and ready to land.Nov 16 2017, 01:34
Closed by commit rABC39aafe4f317b: Make DummyAddress support cashaddr (authored by dagurval). · Explain WhyNov 16 2017, 07:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
qt/
5 lines
49 lines
test/
18 lines
39 lines
3 lines

Diff 1747

View Options

src/Makefile.qttest.include

Loading...
View Options

src/qt/guiutil.h

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/test/guiutiltests.h

Loading...
View Options

src/qt/test/guiutiltests.cpp

Loading...
View Options

src/qt/test/test_main.cpp

Loading...