Page MenuHomePhabricator
Differential D674

Prepare wallet for explicit Amount construction
ClosedPublic
Actions

Authored by schancel on Nov 14 2017, 00:13.

Details

Reviewers
deadalnix
freetrader
Group Reviewers
Restricted Project
Commits
rSTAGING0b7abd9bd414: Prepare wallet for explicit Amount construction
rABC0b7abd9bd414: Prepare wallet for explicit Amount construction
Summary

Continue T104

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallet-cpp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1139
Build 1139: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 14 2017, 00:13
Harbormaster completed remote builds in B1108: Diff 1727.Nov 14 2017, 00:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 14 2017, 00:13
Herald added a reviewer: Restricted Project. · View Herald Transcript
deadalnix requested changes to this revision.Nov 14 2017, 14:57
deadalnix added inline comments.
src/wallet/wallet.cpp
2713 ↗(On Diff #1727)

typeof(Amount / intergral) == Amount

2720 ↗(On Diff #1727)
typeof(Amount % intergral) == Amount
This revision now requires changes to proceed.Nov 14 2017, 14:57
schancel added inline comments.Nov 15 2017, 18:00
src/wallet/wallet.cpp
2720 ↗(On Diff #1727)

We got rid of this operator. Do you want it added back?

deadalnix added inline comments.Nov 15 2017, 18:01
src/wallet/wallet.cpp
2720 ↗(On Diff #1727)

I think we should granted the right types are used. It seems like it is useful. When you force people to jump through hoops to do something legit, you end up with more errors at the end.

schancel updated this revision to Diff 1772.Nov 16 2017, 00:04

Add modulus operator and use in the wallet.

Harbormaster completed remote builds in B1139: Diff 1772.Nov 16 2017, 00:04
deadalnix accepted this revision.Nov 16 2017, 10:30
This revision is now accepted and ready to land.Nov 16 2017, 10:30
Closed by commit rABC0b7abd9bd414: Prepare wallet for explicit Amount construction (authored by schancel). · Explain WhyNov 16 2017, 18:39
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines
wallet/
22 lines
112 lines

Diff 1772

View Options

src/amount.h

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...