Page MenuHomePhabricator
Differential D717

Move the declaration of various json conversion function in rpc/tojson.h
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2017, 15:28.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9034ff1c2dd8: Move the declaration of various json conversion function in rpc/tojson.h
rABC9034ff1c2dd8: Move the declaration of various json conversion function in rpc/tojson.h
Summary

They are delcared in multiple places, which is not very maintainable.

Test Plan
make check
../qa/pull-tester/rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpctxjson
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1169
Build 1169: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2017, 15:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2017, 15:28
Harbormaster completed remote builds in B1169: Diff 1829.Nov 25 2017, 15:28
schancel accepted this revision.Nov 27 2017, 02:57
This revision is now accepted and ready to land.Nov 27 2017, 02:57
Closed by commit rABC9034ff1c2dd8: Move the declaration of various json conversion function in rpc/tojson.h (authored by deadalnix). · Explain WhyNov 27 2017, 03:07
This revision was automatically updated to reflect the committed changes.
markblundeberg mentioned this in D3013: [rpc] Move tojson.h into blockchain.h.May 10 2019, 05:13
Diffusion mentioned this in rABC4967c68c3891: [rpc] Move tojson.h into blockchain.h.May 13 2019, 19:41
markblundeberg mentioned this in D3070: Remove config argument from blockToJSON.May 19 2019, 17:26
Diffusion mentioned this in rABCe1039399e967: Remove config argument from blockToJSON.May 20 2019, 22:59
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGING4967c68c3891: [rpc] Move tojson.h into blockchain.h.Sep 18 2019, 23:30
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGe1039399e967: Remove config argument from blockToJSON.Sep 18 2019, 23:38

Revision Contents
Changeset List

PathSize
src/
1 line
15 lines
rpc/
22 lines
17 lines
22 lines

Diff 1829

View Options

src/Makefile.am

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/tojson.h

Loading...